rdhabalia commented on a change in pull request #2351: Avoid double executor on
non-persistent topic send operation
URL: https://github.com/apache/incubator-pulsar/pull/2351#discussion_r209116025
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java
##########
@@ -188,44 +188,32 @@ public NonPersistentTopic(String topic, BrokerService
brokerService) {
@Override
public void publishMessage(ByteBuf data, PublishContext callback) {
- AtomicInteger msgDeliveryCount = new AtomicInteger(2);
+ callback.completed(null, 0L, 0L);
ENTRIES_ADDED_COUNTER_UPDATER.incrementAndGet(this);
- // retain data for sub/replication because io-thread will release
actual payload
- data.retain(2);
- this.executor.executeOrdered(topic, SafeRun.safeRun(() -> {
- subscriptions.forEach((name, subscription) -> {
- ByteBuf duplicateBuffer = data.retainedDuplicate();
- Entry entry = create(0L, 0L, duplicateBuffer);
- // entry internally retains data so, duplicateBuffer should be
release here
- duplicateBuffer.release();
- if (subscription.getDispatcher() != null) {
-
subscription.getDispatcher().sendMessages(Lists.newArrayList(entry));
- } else {
- // it happens when subscription is created but dispatcher
is not created as consumer is not added
- // yet
- entry.release();
- }
- });
- data.release();
- if (msgDeliveryCount.decrementAndGet() == 0) {
- callback.completed(null, 0L, 0L);
+ subscriptions.forEach((name, subscription) -> {
+ ByteBuf duplicateBuffer = data.retainedDuplicate();
+ Entry entry = create(0L, 0L, duplicateBuffer);
+ // entry internally retains data so, duplicateBuffer should be
release here
+ duplicateBuffer.release();
+ if (subscription.getDispatcher() != null) {
+
subscription.getDispatcher().sendMessages(Collections.singletonList(entry));
Review comment:
I think idea was to hand over publish part to worker thread and let
io-thread be free immediately. but it seems io thread is not doing much here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
