rdhabalia closed pull request #2353: Set correct exception if function runnable
fails with Error
URL: https://github.com/apache/incubator-pulsar/pull/2353
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
index aea9d53d93..fe94b179f8 100644
---
a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
+++
b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
@@ -185,8 +185,10 @@ ContextImpl setupContext() {
*/
@Override
public void run() {
+ String functionName = null;
try {
ContextImpl contextImpl = setupContext();
+ functionName = String.format("%s-%s", contextImpl.getTenant(),
contextImpl.getFunctionName());
javaInstance = setupJavaInstance(contextImpl);
if (null != stateTable) {
StateContextImpl stateContext = new
StateContextImpl(stateTable);
@@ -233,8 +235,8 @@ public void run() {
}
}
} catch (Throwable t) {
- log.error("Uncaught exception in Java Instance", t);
- deathException = (Exception) t;
+ log.error("[{}] Uncaught exception in Java Instance",
functionName, t);
+ deathException = t;
return;
} finally {
log.info("Closing instance");
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
