srkukarni commented on a change in pull request #2266: Integrate functions and
io with schema registry
URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r209824852
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
##########
@@ -204,14 +207,27 @@ void runCmd() throws Exception {
@Parameter(names = { "-t", "--sink-type" }, description = "The sinks's
connector provider")
protected String sinkType;
- @Parameter(names = "--inputs", description = "The sink's input topic
or topics (multiple topics can be specified as a comma-separated list)")
+ @Parameter(names = { "-i",
+ "--inputs" }, description = "The sink's input topic or topics
(multiple topics can be specified as a comma-separated list)")
protected String inputs;
- @Parameter(names = "--topicsPattern", description = "TopicsPattern to
consume from list of topics under a namespace that match the pattern. [--input]
and [--topicsPattern] are mutually exclusive. Add SerDe class name for a
pattern in --customSerdeInputs (supported for java fun only)")
+
+ @Parameter(names = "--topicsPattern", description = "TopicsPattern to
consume from list of topics under a namespace that match the pattern. [--input]
and [--topicsPattern] are mutually exclusive. Add SerDe class name for a
pattern in --customSerdeInputs (supported for java fun only)", hidden = true)
protected String topicsPattern;
+
+ @Parameter(names = { "-st",
+ "--schema-type" }, description = "The builtin schema type (eg:
'avro', 'json', etc..) or the class name for a Schema or Serde implementation")
+ protected String schemaTypeOrClassName = "";
+
@Parameter(names = "--subsName", description = "Pulsar source
subscription name if user wants a specific subscription-name for input-topic
consumer")
protected String subsName;
- @Parameter(names = "--customSerdeInputs", description = "The map of
input topics to SerDe class names (as a JSON string)")
+
+ @Parameter(names = "--customSerdeInputs", description = "The map of
input topics to SerDe class names (as a JSON string)", hidden = true)
protected String customSerdeInputString;
Review comment:
Thats the style that we have followed elsewhere in CmdFunctions, so might be
useful to follow the same. Will be easier to clean these things later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
