sijie commented on a change in pull request #2367: [compaction] make topic
compaction works with partitioned topic
URL: https://github.com/apache/incubator-pulsar/pull/2367#discussion_r209868872
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/compaction/TwoPhaseCompactor.java
##########
@@ -105,7 +105,6 @@ private void phaseOneLoop(RawReader reader,
return;
}
CompletableFuture<RawMessage> future = reader.readNextAsync();
- scheduleTimeout(future);
Review comment:
the timeout was introduced because we don't have getLastMessageId. but since
we introduced getLastMessageId so we know what is the last message id at the
time we start compaction, so the reader should be able to read all message till
last message id, we don't need to use timeout anymore.
actually timeout makes the compaction behavior *underministic* and hide the
problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
