jerrypeng commented on a change in pull request #2266: Integrate functions and
io with schema registry
URL: https://github.com/apache/incubator-pulsar/pull/2266#discussion_r210615887
##########
File path:
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfig.java
##########
@@ -71,19 +66,19 @@
private String name;
@NotNull
private String className;
- @isListEntryCustom(entryValidatorClasses =
{ValidatorImpls.TopicNameValidator.class})
- private Collection<String> inputs;
- @isMapEntryCustom(keyValidatorClasses = {
ValidatorImpls.TopicNameValidator.class },
- valueValidatorClasses = { ValidatorImpls.SerdeValidator.class },
targetRuntime = ConfigValidation.Runtime.JAVA)
- @isMapEntryCustom(keyValidatorClasses = {
ValidatorImpls.TopicNameValidator.class }, targetRuntime =
ConfigValidation.Runtime.PYTHON)
- private Map<String, String> customSerdeInputs;
- @isValidTopicName
- private String topicsPattern;
+
+ private Map<String, ConsumerConfig> inputSpecs = new TreeMap<>();
+
@isValidTopicName
private String output;
+
+ /**
+ * Represents either a builtin schema type (eg: 'avro', 'json', ect) or
the class name for a Schema or SerDe
+ * implementation
+ */
+ private String outputSchemaOrClassName;
+
private boolean skipOutput;
- @isImplementationOfClass(implementsClass = SerDe.class)
- private String outputSerdeClassName;
Review comment:
Deleting any variables in FunctionConfig can potentially break backwards
compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
