codelipenghui commented on a change in pull request #2400: Dead Letter Topic
URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211182494
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -867,9 +867,9 @@ protected void internalCreateSubscription(String
subscriptionName, MessageIdImpl
if (topic.getSubscriptions().containsKey(subscriptionName)) {
throw new RestException(Status.CONFLICT, "Subscription
already exists for topic");
}
-
+ //TODO support dead letter topic in admin
Review comment:
It's not useful any more because client subscribe can update the max
redelivery count and dead letter topic name. I will delete the TODO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
