sijie commented on a change in pull request #2397: Integrate Functions with
Schema
URL: https://github.com/apache/incubator-pulsar/pull/2397#discussion_r211366341
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
##########
@@ -469,20 +477,56 @@ protected FunctionDetails createSinkConfig(SinkConfig
sinkConfig) throws IOExcep
// set source spec
// source spec classname should be empty so that the default
pulsar source will be used
SourceSpec.Builder sourceSpecBuilder = SourceSpec.newBuilder();
+
sourceSpecBuilder.setSubscriptionType(Function.SubscriptionType.SHARED);
Review comment:
I think it is still very confused about
`--inputs`
`--topics-pattern`
`--customSerdeInputs`
`--customSchemaInputs`
@merlimat @srkukarni - can you guys describe what is the eventual options
for users to use? any options should be marked as hidden (to deprecate)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
