srkukarni commented on a change in pull request #2424: Support heartbeat
function for worker
URL: https://github.com/apache/incubator-pulsar/pull/2424#discussion_r212389886
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
##########
@@ -143,7 +143,7 @@ public static WorkerConfig load(String yamlFile) throws
IOException {
public String getWorkerId() {
if (StringUtils.isBlank(this.workerId)) {
- this.workerId = getWorkerHostname();
+ this.workerId = String.format("%s-%s", this.getWorkerHostname(),
this.getWorkerPort());
Review comment:
This change has implications for other places where both workerId and
workerport are being used. Maybe add a seperate function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
