merlimat commented on a change in pull request #2400: PIP-22: Dead Letter Topic
URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r212524714
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -229,6 +229,16 @@ message CommandSubscribe {
// Signal wthether the subscription will initialize on latest
// or not -- earliest
optional InitialPosition initialPosition = 13 [default = Latest];
+ // Maximum number of redeliveries.
+ // Message exceeding the maximum number of redeliveries should send to
Dead Letter Topic and acknowledged automatic.
+ // Enable this feature by set maxRedeliveryCount > 0
+ optional int32 maxRedeliveryCount = 14;
+ // Name of Dead Letter Topic.
+ // If not set, pulsar broker will generate with topic name and
subscription name and suffix with -DLQ
+ optional string deadLetterTopic = 15;
Review comment:
I think it's a bit dangerous to leave the option to have a large number of
possible topics for which we need to create producer objects inside the broker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
