codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter
Topic
URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r212575842
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursor.java
##########
@@ -75,6 +78,16 @@
*/
Map<String, Long> getProperties();
+ /**
+ * Return entry at the position.
+ */
+ Entry readEntry(PositionImpl position) throws InterruptedException,
ExecutionException;
Review comment:
When i use asyncReplayEntries(), i should change ConcurrentLongPairSet to
Set<Position> then call asyncReplayEntries() and in asyncReplayEntries()
implement call ledger.asyncReadEntry() foreach. So i think i need a readEntry()
method to read entry that no need to change ConcurrentLongPairSet to
Set<Position>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
