merlimat closed pull request #2425: Standalone bookie should always advertise
'localhost' when running in docker container
URL: https://github.com/apache/incubator-pulsar/pull/2425
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java
b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java
index 3e44f761e2..cf07d8c8ba 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java
@@ -253,7 +253,8 @@ void start() throws Exception {
if (!this.isOnlyBroker()) {
// Start LocalBookKeeper
bkEnsemble = new LocalBookkeeperEnsemble(
- this.getNumOfBk(), this.getZkPort(), this.getBkPort(),
this.getStreamStoragePort(), this.getZkDir(), this.getBkDir(),
this.isWipeData(), config.getAdvertisedAddress());
+ this.getNumOfBk(), this.getZkPort(), this.getBkPort(),
this.getStreamStoragePort(), this.getZkDir(),
+ this.getBkDir(), this.isWipeData(), "127.0.0.1");
bkEnsemble.startStandalone(!this.isNoStreamStorage());
}
@@ -352,7 +353,7 @@ private void createSampleNameSpace(URL webServiceUrl,
String brokerServiceUrl, S
log.info(e.getMessage());
}
}
-
+
/** this methods gets a buidler to use to build and an embedded pulsar
instance `
* i.e.
* <pre>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
