jerrypeng commented on a change in pull request #2445: Remove schema validator
from annotations
URL: https://github.com/apache/incubator-pulsar/pull/2445#discussion_r212777446
##########
File path:
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SourceConfig.java
##########
@@ -58,7 +58,6 @@
@isImplementationOfClass(implementsClass = SerDe.class)
private String serdeClassName;
- @isImplementationOfClass(implementsClass = Schema.class)
Review comment:
why do we need to remove this. Shouldn't we check if the class implements
Schema?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
