merlimat closed pull request #2444: fix issue with protocol version not being
correct
URL: https://github.com/apache/incubator-pulsar/pull/2444
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
index 02443ccf13..7287194f62 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
@@ -243,8 +243,9 @@ protected void handleConnected(CommandConnected connected) {
if (log.isDebugEnabled()) {
log.debug("{} Connection is ready", ctx.channel());
}
- connectionFuture.complete(null);
+ // set remote protocol version to the correct version before we
complete the connection future
remoteEndpointProtocolVersion = connected.getProtocolVersion();
+ connectionFuture.complete(null);
state = State.Ready;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
