sijie commented on a change in pull request #2440: Issue 2313: create a JDBC 
sink connector
URL: https://github.com/apache/incubator-pulsar/pull/2440#discussion_r213140305
 
 

 ##########
 File path: 
tests/integration/src/test/java/org/apache/pulsar/tests/integration/suites/PulsarTestSuite.java
 ##########
 @@ -60,10 +62,19 @@ protected PulsarClusterSpecBuilder 
beforeSetupCluster(String clusterName, Pulsar
                 .withCreateContainerCmdModifier(createContainerCmd -> 
createContainerCmd
                     .withName(kafkaServiceName)
                     .withHostName(clusterName + "-" + kafkaServiceName)));
+
         final String cassandraServiceName = "cassandra";
         externalServices.put(
             cassandraServiceName,
             new CassandraContainer(clusterName));
+
+        // use mySQL for jdbc test
+        final String jdbcServiceName = "jdbc";
+        externalServices.put(
+            jdbcServiceName,
+            new MySQLContainer()
 
 Review comment:
   attach clusterName to the hostname
   
   ```
   new MySQLContainer()
        .withNetworkAliases(jdbcServiceName)
        .withCreateContainerCmdModifier(createContainerCmd -> 
createContainerCmd                        
                       .withName(jdbcServiceName)
                       .withHostName(clusterName + "-" + jdbcServiceName)));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to