jiazhai closed pull request #2458: Fixed few links in contact and download pages
URL: https://github.com/apache/incubator-pulsar/pull/2458
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/site2/website/core/Footer.js b/site2/website/core/Footer.js
index 40f21c41ce..d59ffe1f55 100644
--- a/site2/website/core/Footer.js
+++ b/site2/website/core/Footer.js
@@ -115,13 +115,13 @@ class Footer extends React.Component {
   render() {
     const currentYear = new Date().getFullYear();
 
-    const contactUrl = this.pageUrl('contact')
-    const eventsUrl = this.pageUrl('events')
+    const contactUrl = this.pageUrl('contact', this.props.language)
+    const eventsUrl = this.pageUrl('events', this.props.language)
     const twitterUrl = 'https://twitter.com/Apache_Pulsar'
     const wikiUrl = 'https://github.com/apache/incubator-pulsar/wiki'
     const issuesUrl = 'https://github.com/apache/incubator-pulsar/issues'
-    const resourcesUrl = this.pageUrl('resources')
-    const teamUrl = this.pageUrl('team')
+    const resourcesUrl = this.pageUrl('resources', this.props.language)
+    const teamUrl = this.pageUrl('team', this.props.language)
 
     const communityMenuJs = `
       const community = 
document.querySelector("a[href='#community']").parentNode;
diff --git a/site2/website/pages/en/contact.js 
b/site2/website/pages/en/contact.js
index 45f841653f..2a662ac5e7 100644
--- a/site2/website/pages/en/contact.js
+++ b/site2/website/pages/en/contact.js
@@ -46,13 +46,13 @@ class Contact extends React.Component {
               <h1><translate>Contact</translate></h1>
               <hr />
             </header>
-            <p>
+            <p><translate>
             There are many ways to get help from the Apache Pulsar community.
             The mailing lists are the primary place where all Pulsar 
committers are present.
             Bugs and feature requests can either be discussed on the dev 
mailing list or
             by opening an issue on
             <a href="https://github.com/apache/incubator-pulsar/"; 
target="_blank">GitHub</a>.
-            </p>
+            </translate></p>
 
             <h2><translate>Mailing Lists</translate></h2>
             <table className="versions">
@@ -83,10 +83,10 @@ class Contact extends React.Component {
             <h2><translate>Slack</translate></h2>
             <p><translate>There is a Pulsar slack channel that is used for 
informal discussions for devs and users.</translate></p>
 
-            <p><translate>The Slack instance is at </translate><a 
href="https://apache-pulsar.slack.com/"; target="_blank">
+            <p><translate>The Slack instance is at </translate> <a 
href="https://apache-pulsar.slack.com/"; target="_blank">
                     https://apache-pulsar.slack.com/</a></p>
 
-            <p><translate>You can self-register at </translate><a 
href="https://apache-pulsar.herokuapp.com/"; target="_blank">
+            <p><translate>You can self-register at </translate> <a 
href="https://apache-pulsar.herokuapp.com/"; target="_blank">
                     https://apache-pulsar.herokuapp.com/</a></p>
           </div>
         </Container>
diff --git a/site2/website/pages/en/download.js 
b/site2/website/pages/en/download.js
index 5960cb12d7..f952814758 100644
--- a/site2/website/pages/en/download.js
+++ b/site2/website/pages/en/download.js
@@ -98,7 +98,7 @@ class Download extends React.Component {
             <h2><translate>Release notes</translate></h2>
             <div>
               <p>
-                <a href={`${siteConfig.baseUrl}/release-notes`}>Release 
notes</a> for all Pulsar's versions
+                <a 
href={`${siteConfig.baseUrl}${this.props.language}/release-notes`}>Release 
notes</a> for all Pulsar's versions
               </p>
             </div>
 
diff --git a/site2/website/pages/en/team.js b/site2/website/pages/en/team.js
index 453b6bc937..a85104bdc2 100644
--- a/site2/website/pages/en/team.js
+++ b/site2/website/pages/en/team.js
@@ -17,37 +17,37 @@ const team = require(`${CWD}/data/team.js`)
 class Team extends React.Component {
   render() {
     let language = this.props.language || '';
-    
+
 
     return (
       <div className="docMainWrapper wrapper">
         <Container className="mainContainer documentContainer postContainer">
           <div className="post">
             <header className="postHeader">
-              <h1><translate>Contact</translate></h1>
+              <h1><translate>Team</translate></h1>
               <hr />
             </header>
             <p>
             <translate>
-              A successful project requires many people to play many roles. 
-              Some members write code or documentation, while others are 
valuable as testers, 
+              A successful project requires many people to play many roles.
+              Some members write code or documentation, while others are 
valuable as testers,
               submitting patches and suggestions.
             </translate>
             </p>
             <p>
             <translate>
-              The team is comprised of Members and Contributors. 
-              Members have direct access to the source of a project and 
actively evolve the codebase. 
-              Contributors improve the project through submission of patches 
and 
-              suggestions to the Members. The number of Contributors to the 
project is unbounded. 
+              The team is comprised of Members and Contributors.
+              Members have direct access to the source of a project and 
actively evolve the codebase.
+              Contributors improve the project through submission of patches 
and
+              suggestions to the Members. The number of Contributors to the 
project is unbounded.
               Get involved today. All contributions to the project are greatly 
appreciated.
             </translate>
             </p>
-            
+
             <h2><translate>Committers</translate></h2>
             <p>
             <translate>
-              The following is a list of developers with commit privileges 
that have directly 
+              The following is a list of developers with commit privileges 
that have directly
               contributed to the project in one way or another.
             </translate>
             </p>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to