rdhabalia commented on a change in pull request #2468: Fix semantics of skip
output
URL: https://github.com/apache/incubator-pulsar/pull/2468#discussion_r213468915
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -477,9 +477,8 @@ void processArguments() throws Exception {
protected void validateFunctionConfigs(FunctionConfig functionConfig) {
- if (isBlank(functionConfig.getOutput()) &&
!functionConfig.isSkipOutput()) {
- throw new ParameterException(
Review comment:
I thought with #2261 we decided with @sijie 's feedback to "fail fast" if
there is a conflict because output-topic name and skip-output are mutually
exclusive and user should not use it together. so, does it make sense to give
error-message to clarify role of the input skipoutput flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
