srkukarni commented on a change in pull request #2468: Fix semantics of skip
output
URL: https://github.com/apache/incubator-pulsar/pull/2468#discussion_r213503121
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -477,9 +477,8 @@ void processArguments() throws Exception {
protected void validateFunctionConfigs(FunctionConfig functionConfig) {
- if (isBlank(functionConfig.getOutput()) &&
!functionConfig.isSkipOutput()) {
- throw new ParameterException(
Review comment:
skipOutput flag is currently very misleading. From the description it seems
that you can run a function and pass this flag to suppress any output. Thus if
you provide an output topic and specify skipOutput, this flag will nullify the
output topic. Maybe I can print a message while nulliyfing the output topic.
Otherwise I really don't understand the need for skipOutput. One other thing
that we can do that if output topic is not set, don;'t write it. That might be
a cleaner/clearer way than this whole outputTopic and skipOutput combination.
What do you think @sijie @rdhabalia @jerrypeng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
