merlimat commented on a change in pull request #2471: Pulsar Java Client 
Interceptors.
URL: https://github.com/apache/incubator-pulsar/pull/2471#discussion_r213769267
 
 

 ##########
 File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainer.java
 ##########
 @@ -105,7 +105,6 @@ void add(MessageImpl<?> msg, SendCallback callback) {
         batchedMessageMetadataAndPayload = 
Commands.serializeSingleMessageInBatchWithPayload(msgBuilder,
                 msg.getDataBuffer(), batchedMessageMetadataAndPayload);
         messages.add(msg);
-        msgBuilder.recycle();
 
 Review comment:
   Any reason for why the message builder cannot be recycled anymore?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to