rdhabalia commented on a change in pull request #2487: Ensure standalone
service comes back quickly after ungraceful restarts
URL: https://github.com/apache/incubator-pulsar/pull/2487#discussion_r214143078
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
##########
@@ -791,9 +791,26 @@ public void start() throws PulsarServerException {
} catch (KeeperException.NodeExistsException e) {
long ownerZkSessionId = getBrokerZnodeOwner();
if (ownerZkSessionId != 0 && ownerZkSessionId !=
zkClient.getSessionId()) {
- log.error("Broker znode - [{}] is own by different
zookeeper-ssession {} ", brokerZnodePath,
- ownerZkSessionId);
- throw new PulsarServerException("Broker-znode owned by
different zk-session " + ownerZkSessionId);
+ if (conf.isRunningStandalone()) {
Review comment:
I don't feel it is a right place.. this is something related to only
standalone server and I think it makes more sense to add startup-clean up at
`PulsarStandaloneStarter` because we can have different `LoadManager`
implementation and we don't want to repeat this logic which is specific to
standalone broker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
