merlimat commented on a change in pull request #2496: Fix: auto-ack flag always
set true
URL: https://github.com/apache/incubator-pulsar/pull/2496#discussion_r214215417
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -312,7 +312,7 @@ void processArguments() throws Exception {
@Parameter(names = "--autoAck", description = "Whether or not the
framework will automatically acknowleges messages", hidden = true)
protected Boolean DEPRECATED_autoAck = null;
@Parameter(names = "--auto-ack", description = "Whether or not the
framework will automatically acknowleges messages")
- protected Boolean autoAck ;
+ protected boolean autoAck ;
Review comment:
@rdhabalia With JCommander shouldn't it be able to handle boolean flags with
default value to `true` ?
Eg. with :
```java
protected boolean autoAck = true;
```
shouldn't be working to pass `--auto-ack=false` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
