srkukarni commented on a change in pull request #2546: Elastic connector
URL: https://github.com/apache/incubator-pulsar/pull/2546#discussion_r216108285
##########
File path:
tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
##########
@@ -80,18 +88,23 @@ public void testHdfsSink() throws Exception {
@Test
public void testJdbcSink() throws Exception {
- testSink(new JdbcSinkTester(), true);
+ testSink(new JdbcSinkTester());
+ }
+
+ @Test
+ public void testElasticSearchSink() throws Exception {
+ testSink(new ElasticSearchSinkTester());
}
- private void testSink(SinkTester tester, boolean builtin) throws Exception
{
+ private void testSink(SinkTester tester) throws Exception {
Review comment:
I think a bunch of changes were reverted from master by mistake?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
