rdhabalia commented on a change in pull request #2549: [Function] avoid 
creating assignment snapshot and publish individual assignment msg
URL: https://github.com/apache/incubator-pulsar/pull/2549#discussion_r217938965
 
 

 ##########
 File path: 
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionAssignmentTailer.java
 ##########
 @@ -34,15 +36,16 @@
         private final FunctionRuntimeManager functionRuntimeManager;
         private final Reader<byte[]> reader;
 
 Review comment:
   actually, it seems built-in `ProtobufSchema` couldn't deserialize 
`Function.Assignment` so, it seems it will require to add custom-schema and 
also, for deleted keys if topic is not compacted yet then consumer can consume 
message with empty-payload where consumer doesn't need to deserialize and 
AssignmentManager can directly delete assignment without deserializing message. 
so, i think keeping raw byte[] might be better choice.?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to