FtD Code Review Notes has been edited by Martin Ritchie (Mar 09, 2009).

(View changes)

Content:

Flow to Disk review points

Priority (H/M/L) Review Status
High Removal of old methods from TransactionLog  
  Create Abstract BaseTransactionLog class to hold commonalities with existing TLogs  
  Refactor Ref Counting out into BaseTransactionLog  
  StoreContext update, initially to include the dequeue messageIds as per BDBStore  
  StoreContext -> convert -> Transaction and use that for operation.(commit,abort...)  
  Reference Count to use AtomicInts to reduce memory usage.  
  Rename flow/recover -> unload/load Done
High FlowableQueueEntryList extends QueueEntryList, but there are no unflowable lists, and there shouldn't be in the future either. (AS)
Done
  Merge Inhaler/Purger threads to a single rebalance thread  
  QueueEntryImpl allows direct access to the ContentHeader via the Filterable Interface, need an improved way of doing selectors that doesn't always require the message to be pulled from disk. Some checks can be done with data already in memory with QueueEntry; MessageID  
  NoLocal requires message to be pulled in to memory.  

--------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]

Reply via email to