| ID |
Raised By |
Description |
Status |
Outcome |
| 1 |
RG |
Requirements 5,6,8,9 are design choices |
|
|
| 2 |
RG |
Requirement 10 is observation / scope limit |
|
|
| 3 |
RG |
Requirement 7 should be removed |
|
|
| 4 |
RG |
Requirement 9 expand buffering of bytes before wire, writers are not synch it's about the contract. Similar to requirement 5 |
|
|
| 5 |
MM |
Requirement 3 should be reworded since it's not exposing methods |
|
|
| 6 |
RG |
Explain configuration interface better later in documentation |
|
|
| 7 |
MM |
Document needs better flow requirements, current implemenation, new implemntation, dont' see how it all hangs together |
|
|
| 8 |
MM |
Doesn't highlight current problems |
|
|
| 9 |
LB |
Link to reason why we're doing this work |
|
|
| 10 |
RG |
Previous / current design - move out and list w/explanation of what is wrong, link here and can then provide what is being done to address theis. |
|
|
| 11 |
RG |
Add link to old design parts |
|
|
| 12 |
MM |
Not clear how docs link together. Hard to review, tick boxes w/out expected content defined |
|
|
| 13 |
RG |
new implemntation needs to specify that protocol engine turns frames into bytes |
|
|
| 14 |
RG |
Move diagram / overview of approach top top before detailed discussion |
|
|
| 15 |
RG |
Highlight that phase 1 is removing MINA leakage behind new interfaces and that's all |
|
|
| 16 |
MM |
Highlight now and phase 1, show MINA leakage |
|
|
| 17 |
RG |
Phaseing - interfaces, new decoders. Smaller parts better |
|
|
| 18 |
ALL |
new diagram - future state, phase 1 |
|
|
| 19 |
MM |
Description does not tie with interfaces |
|
|
| 20 |
RG |
Interfaces could do with class level doc, how it's used, what it does. Network driver extends sender, explain how it uses sender. ProtocolEngine is a reciever. ND is a sender |
|
|
| 21 |
MM |
Hard to see links between sender/reciever and class |
|
|
| 22 |
RG |
Put more details about the abstract interfaces and the concrete classes later when we talk about this and refer back to interfaces |
|
|
| 23 |
MM |
ND clearer seperation between what is Sender and what is ND and that ND extends Sender |
|
|
| 24 |
MM |
Need state transition diagram to show data transfer |
|
|
| 25 |
RG |
Sequence diagram showing flow of control |
|
|
| 26 |
RG |
Detail to do with Job should move to impl doc |
|
|
| 27 |
MM |
Exception handling on interfaces, open, bind, configuration |
|
|
| 28 |
RG |
Mention exception needs handled, throws OpenExcep/BindExcept. NOT AMQE. AMQE delenda est |
|
|
| 29 |
RG |
"New design" not new implementation |
|
|
| 30 |
RG |
ProtocolEngine desc should mention that it also converts frames to bytes |
|
|
| 31 |
RG |
NetworkDriverConfiguration needs to text to explain what is going with these details |
|
|
| 32 |
RG |
Reduce interface diagram to just who network driver / protocol engine |
|
|
| 33 |
MM |
Highlight difference with old |
|
|
| 34 |
RG/MR |
map ND -> MINA, Rest -> Decoder |
|
|
| 35 |
RG |
Highlight lack of MINA leakage |
|
|
| 36 |
RG |
Implementation details (AMQProtocolEngine_0_N) should be removed |
|
|
