Author: kwall
Date: Wed Feb 8 11:11:45 2012
New Revision: 1241866
URL: http://svn.apache.org/viewvc?rev=1241866&view=rev
Log:
QPID-3820: Sporadic failures from ProducerFlowControlTest
The tests rely on a sync() to make sure the Broker has received the sent
messages and has had a chance to invoke flow-control. However,
a defect in tests testClientLogMessages and testSendTimeout meant that an
inactive session was actually being sync'd, rather than
the one used to produce the messages. This will probably explain the sporadic
failure.
Modified:
qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/queue/ProducerFlowControlTest.java
Modified:
qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/queue/ProducerFlowControlTest.java
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/queue/ProducerFlowControlTest.java?rev=1241866&r1=1241865&r2=1241866&view=diff
==============================================================================
---
qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/queue/ProducerFlowControlTest.java
(original)
+++
qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/queue/ProducerFlowControlTest.java
Wed Feb 8 11:11:45 2012
@@ -178,7 +178,7 @@ public class ProducerFlowControlTest ext
producer = session.createProducer(queue);
// try to send 5 messages (should block after 4)
- MessageSender sender = sendMessagesAsync(producer, producerSession, 5,
50L);
+ MessageSender sender = sendMessagesAsync(producer, session, 5, 50L);
List<String> results = waitAndFindMatches("Message send delayed by",
TIMEOUT);
assertTrue("No delay messages logged by client",results.size()!=0);
@@ -280,7 +280,7 @@ public class ProducerFlowControlTest ext
producer = session.createProducer(queue);
// try to send 5 messages (should block after 4)
- MessageSender sender = sendMessagesAsync(producer, producerSession, 5,
100L);
+ MessageSender sender = sendMessagesAsync(producer, session, 5, 100L);
Exception e = sender.awaitSenderException(10000);
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
