Author: rgodfrey
Date: Thu Apr 24 21:09:47 2014
New Revision: 1589882
URL: http://svn.apache.org/r1589882
Log:
QPID-5580 : Address review comments from Keith Wall / remove dead code
Modified:
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
Modified:
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
URL:
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java?rev=1589882&r1=1589881&r2=1589882&view=diff
==============================================================================
---
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
(original)
+++
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
Thu Apr 24 21:09:47 2014
@@ -96,7 +96,6 @@ public abstract class AbstractQueue<X ex
private static final Logger _logger =
Logger.getLogger(AbstractQueue.class);
public static final String SHARED_MSG_GROUP_ARG_VALUE = "1";
- private static final String QPID_NO_GROUP = "qpid.no-group";
private static final QueueNotificationListener NULL_NOTIFICATION_LISTENER
= new QueueNotificationListener()
{
@@ -203,9 +202,6 @@ public abstract class AbstractQueue<X ex
private final CopyOnWriteArrayList<BindingImpl> _bindings = new
CopyOnWriteArrayList<BindingImpl>();
private Map<String, Object> _arguments;
- //TODO : persist creation time
- private long _createTime = System.currentTimeMillis();
-
/** the maximum delivery count for each message on this queue or 0 if
maximum delivery count is not to be enforced. */
@ManagedAttributeField
private int _maximumDeliveryAttempts;
@@ -250,57 +246,6 @@ public abstract class AbstractQueue<X ex
}
}
- public void validate()
- {
- super.validate();
- if (_virtualHost == null)
- {
- throw new IllegalArgumentException("Virtual Host must not be
null");
- }
-
- if (getName() == null)
- {
- throw new IllegalArgumentException("Queue name must not be null");
- }
-
- addChangeListener(new ConfigurationChangeListener()
- {
- @Override
- public void stateChanged(final ConfiguredObject object, final
State oldState, final State newState)
- {
-
- }
-
- @Override
- public void childAdded(final ConfiguredObject object, final
ConfiguredObject child)
- {
-
- }
-
- @Override
- public void childRemoved(final ConfiguredObject object, final
ConfiguredObject child)
- {
-
- }
-
- @Override
- public void attributeSet(final ConfiguredObject object,
- final String attributeName,
- final Object oldAttributeValue,
- final Object newAttributeValue)
- {
- onAttributeChange(attributeName, oldAttributeValue,
newAttributeValue);
- }
- });
- }
-
- private void onAttributeChange(final String attributeName,
- final Object oldAttributeValue,
- final Object newAttributeValue)
- {
-
- }
-
protected void onOpen()
{
super.onOpen();
@@ -421,8 +366,6 @@ public abstract class AbstractQueue<X ex
throw new IllegalConfigurationException("Flow resume size can't be
greater than flow control size");
}
- final String ownerString = getOwner();
-
// Log the creation of this Queue.
// The priorities display is toggled on if we set priorities > 0
getEventLogger().message(_logSubject,
@@ -1453,11 +1396,6 @@ public abstract class AbstractQueue<X ex
}
- public long getCreateTime()
- {
- return _createTime;
- }
-
// ------ Management functions
public long clearQueue()
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
