Author: aconway Date: Mon Jul 7 15:24:11 2014 New Revision: 1608487 URL: http://svn.apache.org/r1608487 Log: NO-JIRA: Fix defects found by coverity.
To view the defects in Coverity Scan visit, http://scan.coverity.com/projects/6?tab=overview ** CID 1224524: Big parameter passed by value (PASS_BY_VALUE) /qpidbuilds/trunk/qpid/cpp/src/tests/BrokerFixture.h: 155 in qpid::tests::SessionFixtureT<qpid::tests::LocalConnection, qpid::client::Session_0_10>::SessionFixtureT(qpid::broker::BrokerOptions)() ** CID 1224525: Big parameter passed by value (PASS_BY_VALUE) /qpidbuilds/trunk/qpid/cpp/src/tests/ClientSessionTest.cpp: 108 in qpid::tests::ClientSessionFixture::ClientSessionFixture(qpid::broker::BrokerOptions)() ** CID 1224526: Big parameter passed by value (PASS_BY_VALUE) /qpidbuilds/trunk/qpid/cpp/src/tests/MessagingFixture.h: 106 in qpid::tests::MessagingFixture::MessagingFixture(qpid::broker::BrokerOptions, bool)() ** CID 1224527: Wrapper object use after free (WRAPPER_ESCAPE) /qpidbuilds/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp: 276 in qpid::broker::CyrusAuthenticator::init()() Modified: qpid/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp qpid/trunk/qpid/cpp/src/tests/BrokerFixture.h qpid/trunk/qpid/cpp/src/tests/ClientSessionTest.cpp qpid/trunk/qpid/cpp/src/tests/MessagingFixture.h Modified: qpid/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp?rev=1608487&r1=1608486&r2=1608487&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp Mon Jul 7 15:24:11 2014 @@ -272,10 +272,10 @@ void CyrusAuthenticator::init() */ int code; - const char *realm = connection.getBroker().getRealm().c_str(); + std::string realm = connection.getBroker().getRealm(); code = sasl_server_new(BROKER_SASL_NAME, /* Service name */ NULL, /* Server FQDN, gethostname() */ - realm, /* Authentication realm */ + realm.c_str(), /* Authentication realm */ NULL, /* Local IP, needed for some mechanism */ NULL, /* Remote IP, needed for some mechanism */ NULL, /* Callbacks */ Modified: qpid/trunk/qpid/cpp/src/tests/BrokerFixture.h URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/BrokerFixture.h?rev=1608487&r1=1608486&r2=1608487&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/BrokerFixture.h (original) +++ qpid/trunk/qpid/cpp/src/tests/BrokerFixture.h Mon Jul 7 15:24:11 2014 @@ -152,7 +152,7 @@ typedef ClientT<> Client; template <class ConnectionType, class SessionType=qpid::client::Session> struct SessionFixtureT : BrokerFixture, ClientT<ConnectionType,SessionType> { - SessionFixtureT(BrokerOptions opts=BrokerOptions()) : + SessionFixtureT(const BrokerOptions& opts=BrokerOptions()) : BrokerFixture(BrokerFixture::Args(), opts), ClientT<ConnectionType,SessionType>(getPort()) {} Modified: qpid/trunk/qpid/cpp/src/tests/ClientSessionTest.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/ClientSessionTest.cpp?rev=1608487&r1=1608486&r2=1608487&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/ClientSessionTest.cpp (original) +++ qpid/trunk/qpid/cpp/src/tests/ClientSessionTest.cpp Mon Jul 7 15:24:11 2014 @@ -105,7 +105,7 @@ struct SimpleListener : public MessageLi struct ClientSessionFixture : public SessionFixture { - ClientSessionFixture(BrokerOptions opts = BrokerOptions()) : SessionFixture(opts) { + ClientSessionFixture(const BrokerOptions& opts = BrokerOptions()) : SessionFixture(opts) { session.queueDeclare(arg::queue="my-queue"); } }; Modified: qpid/trunk/qpid/cpp/src/tests/MessagingFixture.h URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/MessagingFixture.h?rev=1608487&r1=1608486&r2=1608487&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/tests/MessagingFixture.h (original) +++ qpid/trunk/qpid/cpp/src/tests/MessagingFixture.h Mon Jul 7 15:24:11 2014 @@ -103,7 +103,7 @@ struct MessagingFixture : public BrokerF messaging::Session session; BrokerAdmin admin; - MessagingFixture(BrokerOptions opts = BrokerOptions(), bool mgmtEnabled=false) : + MessagingFixture(const BrokerOptions& opts = BrokerOptions(), bool mgmtEnabled=false) : BrokerFixture(opts, mgmtEnabled), connection(open(broker->getPort(Broker::TCP_TRANSPORT))), session(connection.createSession()), --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
