Author: rgodfrey
Date: Mon Jul 21 14:43:36 2014
New Revision: 1612284

URL: http://svn.apache.org/r1612284
Log:
QPID-5884 : The broker should not NPE if it receives a SASL Init request where 
no mechanism is provided

Modified:
    
qpid/trunk/qpid/java/amqp-1-0-common/src/main/java/org/apache/qpid/amqp_1_0/transport/ConnectionEndpoint.java

Modified: 
qpid/trunk/qpid/java/amqp-1-0-common/src/main/java/org/apache/qpid/amqp_1_0/transport/ConnectionEndpoint.java
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/amqp-1-0-common/src/main/java/org/apache/qpid/amqp_1_0/transport/ConnectionEndpoint.java?rev=1612284&r1=1612283&r2=1612284&view=diff
==============================================================================
--- 
qpid/trunk/qpid/java/amqp-1-0-common/src/main/java/org/apache/qpid/amqp_1_0/transport/ConnectionEndpoint.java
 (original)
+++ 
qpid/trunk/qpid/java/amqp-1-0-common/src/main/java/org/apache/qpid/amqp_1_0/transport/ConnectionEndpoint.java
 Mon Jul 21 14:43:36 2014
@@ -851,14 +851,14 @@ public class ConnectionEndpoint implemen
 
     public void receiveSaslInit(final SaslInit saslInit)
     {
-        Symbol mechanism = saslInit.getMechanism();
+        String mechanism = saslInit.getMechanism() == null ? null : 
saslInit.getMechanism().toString();
         final Binary initialResponse = saslInit.getInitialResponse();
         byte[] response = initialResponse == null ? new byte[0] : 
initialResponse.getArray();
 
 
         try
         {
-            _saslServer = 
_saslServerProvider.getSaslServer(mechanism.toString(), "localhost");
+            _saslServer = _saslServerProvider.getSaslServer(mechanism, 
"localhost");
 
             // Process response from the client
             byte[] challenge = _saslServer.evaluateResponse(response != null ? 
response : new byte[0]);



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to