Author: kwall
Date: Wed Oct  1 15:45:50 2014
New Revision: 1628743

URL: http://svn.apache.org/r1628743
Log:
QPID-6129: [Java Broker] Chain exceptions in Derby/JDBC store implementations

Modified:
    
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCConfigurationStore.java
    
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java

Modified: 
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCConfigurationStore.java
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCConfigurationStore.java?rev=1628743&r1=1628742&r2=1628743&view=diff
==============================================================================
--- 
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCConfigurationStore.java
 (original)
+++ 
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCConfigurationStore.java
 Wed Oct  1 15:45:50 2014
@@ -572,7 +572,7 @@ public abstract class AbstractJDBCConfig
         }
         catch (SQLException e)
         {
-            throw new StoreException("Error creating ConfiguredObject " + 
object);
+            throw new StoreException("Error creating ConfiguredObject " + 
object, e);
         }
     }
 

Modified: 
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java?rev=1628743&r1=1628742&r2=1628743&view=diff
==============================================================================
--- 
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java
 (original)
+++ 
qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/store/AbstractJDBCMessageStore.java
 Wed Oct  1 15:45:50 2014
@@ -133,7 +133,7 @@ public abstract class AbstractJDBCMessag
         }
         catch (SQLException e)
         {
-            throw new StoreException(e);
+            throw new StoreException("Failed to determine maximum ids", e);
         }
 
     }
@@ -816,7 +816,6 @@ public abstract class AbstractJDBCMessag
 
     private void commitTran(ConnectionWrapper connWrapper) throws 
StoreException
     {
-
         try
         {
             Connection conn = connWrapper.getConnection();
@@ -833,10 +832,6 @@ public abstract class AbstractJDBCMessag
         {
             throw new StoreException("Error commit tx: " + e.getMessage(), e);
         }
-        finally
-        {
-
-        }
     }
 
     private StoreFuture commitTranAsync(ConnectionWrapper connWrapper) throws 
StoreException
@@ -1448,7 +1443,7 @@ public abstract class AbstractJDBCMessag
                 }
                 catch (SQLException e)
                 {
-                    throw new StoreException(e);
+                    throw new StoreException("Failed to get metadata for 
message id: " + _messageId, e);
                 }
             }
 
@@ -1507,7 +1502,7 @@ public abstract class AbstractJDBCMessag
                         }
                         catch (SQLException e)
                         {
-                            throw new StoreException(e);
+                            throw new StoreException("Failed to get content 
for message id " + _messageId, e);
                         }
                     }
                     else
@@ -1551,7 +1546,7 @@ public abstract class AbstractJDBCMessag
                         }
                         catch (SQLException e)
                         {
-                            throw new StoreException(e);
+                            throw new StoreException("Failed to get content 
for message id: " + _messageId, e);
                         }
                     }
                     else
@@ -1598,11 +1593,7 @@ public abstract class AbstractJDBCMessag
             }
             catch (SQLException e)
             {
-                throw new StoreException(e);
-            }
-            finally
-            {
-
+                throw new StoreException("Failed to flow to disk", e);
             }
             return true;
         }



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to