add note about need to check limit to prevent excess provider creation attempts
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/8b96bd5c Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/8b96bd5c Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/8b96bd5c Branch: refs/heads/master Commit: 8b96bd5c890d5a01d526507f2e478fe8bbffc543 Parents: 47cf6e4 Author: Robert Gemmell <[email protected]> Authored: Thu Oct 16 12:20:08 2014 +0100 Committer: Robert Gemmell <[email protected]> Committed: Thu Oct 16 16:55:32 2014 +0100 ---------------------------------------------------------------------- .../org/apache/qpid/jms/provider/failover/FailoverProvider.java | 2 ++ 1 file changed, 2 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/8b96bd5c/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/failover/FailoverProvider.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/failover/FailoverProvider.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/failover/FailoverProvider.java index ca8a5e6..77820a6 100644 --- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/failover/FailoverProvider.java +++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/failover/FailoverProvider.java @@ -518,6 +518,8 @@ public class FailoverProvider extends DefaultProviderListener implements Provide return; } + // TODO: if this is already at/past the limit when we arrive, we should + // stop here rather than initialise the provider and only fail (again) after. reconnectAttempts++; Throwable failure = null; URI target = uris.getNext(); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
