NO-JIRA: add some notes for later
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/80f33fc6 Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/80f33fc6 Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/80f33fc6 Branch: refs/heads/master Commit: 80f33fc6a7adeac17683d322acae2f9973dc4211 Parents: 9aabc27 Author: Robert Gemmell <[email protected]> Authored: Fri Aug 21 15:29:44 2015 +0100 Committer: Robert Gemmell <[email protected]> Committed: Fri Aug 21 18:46:29 2015 +0100 ---------------------------------------------------------------------- .../main/java/org/apache/qpid/jms/provider/amqp/AmqpProvider.java | 3 +++ .../main/java/org/apache/qpid/jms/provider/amqp/AmqpSession.java | 1 + 2 files changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/80f33fc6/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpProvider.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpProvider.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpProvider.java index 7383352..ff36ab3 100644 --- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpProvider.java +++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpProvider.java @@ -189,6 +189,7 @@ public class AmqpProvider implements Provider, TransportListener { // just signal success. if (transport == null || !transport.isConnected()) { request.onSuccess(); + //TODO: return here? mark proton connection closed then return? } if (connection != null) { @@ -217,6 +218,7 @@ public class AmqpProvider implements Provider, TransportListener { } } catch (IOException e) { LOG.warn("Error caught while closing Provider: ", e.getMessage()); + //TODO: message can be / seemingly usually is empty } finally { if (transport != null) { try { @@ -740,6 +742,7 @@ public class AmqpProvider implements Provider, TransportListener { LOG.debug("Transport connection remotely closed"); if (!closed.get()) { fireProviderException(new IOException("Transport connection remotely closed.")); + //TODO: close the proton transport as well/instead? if (connection != null) { connection.closed(); } http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/80f33fc6/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSession.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSession.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSession.java index 2dd72fb..46ff1bd 100644 --- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSession.java +++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSession.java @@ -261,6 +261,7 @@ public class AmqpSession extends AmqpAbstractResource<JmsSessionInfo, Session> { return false; } + //TODO: unused? /** * Call to send an error that occurs outside of the normal asynchronous processing * of a session resource such as a remote close etc. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
