Author: rgodfrey
Date: Wed Nov 25 16:31:07 2015
New Revision: 1716474
URL: http://svn.apache.org/viewvc?rev=1716474&view=rev
Log:
QPID-6911 : Api docs for Broker not being displayed
Modified:
qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObjectTypeRegistry.java
qpid/java/trunk/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/HttpManagement.java
qpid/java/trunk/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/ApiDocsServlet.java
Modified:
qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObjectTypeRegistry.java
URL:
http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObjectTypeRegistry.java?rev=1716474&r1=1716473&r2=1716474&view=diff
==============================================================================
---
qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObjectTypeRegistry.java
(original)
+++
qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/ConfiguredObjectTypeRegistry.java
Wed Nov 25 16:31:07 2015
@@ -432,7 +432,7 @@ public class ConfiguredObjectTypeRegistr
}
}
}
- if(typeClass == null && typeName.equals(category.getSimpleName()))
+ if(typeClass == null &&
typeName.equals(category.getSimpleName().toLowerCase()))
{
typeClass = category;
}
Modified:
qpid/java/trunk/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/HttpManagement.java
URL:
http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/HttpManagement.java?rev=1716474&r1=1716473&r2=1716474&view=diff
==============================================================================
---
qpid/java/trunk/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/HttpManagement.java
(original)
+++
qpid/java/trunk/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/HttpManagement.java
Wed Nov 25 16:31:07 2015
@@ -262,7 +262,7 @@ public class HttpManagement extends Abst
addRestServlet(root, Broker.class);
- ServletHolder apiDocsServlet = new ServletHolder(new
ApiDocsServlet(getModel(), Collections.<String>emptyList()));
+ ServletHolder apiDocsServlet = new ServletHolder(new
ApiDocsServlet(getModel()));
final ServletHolder rewriteSerlvet = new ServletHolder(new
RewriteServlet("^(.*)$", "$1/"));
for(String path : new String[]{"/apidocs", "/apidocs/latest",
"/apidocs/"+getLatestSupportedVersion()})
{
Modified:
qpid/java/trunk/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/ApiDocsServlet.java
URL:
http://svn.apache.org/viewvc/qpid/java/trunk/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/ApiDocsServlet.java?rev=1716474&r1=1716473&r2=1716474&view=diff
==============================================================================
---
qpid/java/trunk/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/ApiDocsServlet.java
(original)
+++
qpid/java/trunk/broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet/rest/ApiDocsServlet.java
Wed Nov 25 16:31:07 2015
@@ -58,28 +58,28 @@ public class ApiDocsServlet extends Abst
private static final Map<Class<? extends ConfiguredObject>, List<String>>
REGISTERED_CLASSES = new TreeMap<>(CLASS_COMPARATOR);
+ public ApiDocsServlet(final Model model)
+ {
+ super();
+ _model = model;
+ _hierarchy = null;
+ _types = null;
+ }
+
public ApiDocsServlet(final Model model, final List<String>
registeredPaths, Class<? extends ConfiguredObject>... hierarchy)
{
super();
_model = model;
_hierarchy = hierarchy;
- _types = hierarchy.length == 0 ? null : new
ArrayList<>(_model.getTypeRegistry().getTypeSpecialisations(getConfiguredClass()));
- if(_types != null)
+ _types = new
ArrayList<>(_model.getTypeRegistry().getTypeSpecialisations(getConfiguredClass()));
+ Collections.sort(_types, CLASS_COMPARATOR);
+ List<String> paths = REGISTERED_CLASSES.get(getConfiguredClass());
+ if (paths == null)
{
- Collections.sort(_types, CLASS_COMPARATOR);
+ paths = new ArrayList<>();
+ REGISTERED_CLASSES.put(getConfiguredClass(), paths);
}
- if(_hierarchy.length != 0)
- {
- List<String> paths = REGISTERED_CLASSES.get(getConfiguredClass());
- if(paths == null)
- {
- paths = new ArrayList<>();
- REGISTERED_CLASSES.put(getConfiguredClass(), paths);
- }
- paths.addAll(registeredPaths);
-
- }
-
+ paths.addAll(registeredPaths);
}
@Override
@@ -94,7 +94,7 @@ public class ApiDocsServlet extends Abst
writePreamble(writer);
writeHead(writer);
- if(_hierarchy.length == 0)
+ if(_hierarchy == null)
{
writer.println("<table class=\"api\">");
writer.println("<thead>");
@@ -160,7 +160,7 @@ public class ApiDocsServlet extends Abst
private void writeTitle(final PrintWriter writer)
{
writer.print("<title>");
- if(_hierarchy.length == 0)
+ if(_hierarchy == null)
{
writer.print("Qpid API");
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
