NO-JIRA: update TODO for clarity following change in r1616527
Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/8e890a40 Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/8e890a40 Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/8e890a40 Branch: refs/heads/master Commit: 8e890a40d50599ddc99d71902833f5a04af12aa6 Parents: 092f35c Author: Robert Gemmell <[email protected]> Authored: Thu Jan 21 14:18:46 2016 +0000 Committer: Robert Gemmell <[email protected]> Committed: Thu Jan 21 14:18:46 2016 +0000 ---------------------------------------------------------------------- .../java/org/apache/qpid/proton/engine/impl/TransportImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/8e890a40/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java ---------------------------------------------------------------------- diff --git a/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java b/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java index 87cc57e..93335b0 100644 --- a/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java +++ b/proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java @@ -1093,9 +1093,9 @@ public class TransportImpl extends EndpointImpl } else { - // TODO check null transportSession = _localSessions.get(begin.getRemoteChannel().intValue()); if (transportSession == null) { + // TODO handle failure rather than just throwing a nicer NPE throw new NullPointerException("uncorrelated channel: " + begin.getRemoteChannel()); } session = transportSession.getSession(); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
