Repository: qpid-proton
Updated Branches:
  refs/heads/master acbaa502b -> 822745298


PROTON-1124: Fix missing error handling discovered by Coverity


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/d8537ee7
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/d8537ee7
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/d8537ee7

Branch: refs/heads/master
Commit: d8537ee7dbc3f0b17f94cd8b2c2fcf629e70437c
Parents: acbaa50
Author: Andrew Stitcher <[email protected]>
Authored: Mon Feb 1 17:28:49 2016 -0500
Committer: Andrew Stitcher <[email protected]>
Committed: Tue Feb 2 15:40:00 2016 -0500

----------------------------------------------------------------------
 proton-c/src/message/message.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/d8537ee7/proton-c/src/message/message.c
----------------------------------------------------------------------
diff --git a/proton-c/src/message/message.c b/proton-c/src/message/message.c
index b24a994..cb163d1 100644
--- a/proton-c/src/message/message.c
+++ b/proton-c/src/message/message.c
@@ -665,8 +665,10 @@ int pn_message_decode(pn_message_t *msg, const char 
*bytes, size_t size)
 
     switch (desc) {
     case HEADER:
-      pn_data_scan(msg->data, "D.[oBIoI]", &msg->durable, &msg->priority,
+      err = pn_data_scan(msg->data, "D.[oBIoI]", &msg->durable, &msg->priority,
                    &msg->ttl, &msg->first_acquirer, &msg->delivery_count);
+      if (err) return pn_error_format(msg->error, err, "data error: %s",
+                                      pn_error_text(pn_data_error(msg->data)));
       break;
     case PROPERTIES:
       {


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to