Repository: qpid-jms Updated Branches: refs/heads/master 715540aea -> e97a6f94b
QPIDJMS-168 Fix type some declarations that could be final or static Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/c99ea859 Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/c99ea859 Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/c99ea859 Branch: refs/heads/master Commit: c99ea859d3d6a8015ead5fc99c19dd64c6f0a07c Parents: 715540a Author: Timothy Bish <[email protected]> Authored: Tue Apr 5 12:44:26 2016 -0400 Committer: Timothy Bish <[email protected]> Committed: Tue Apr 5 12:44:26 2016 -0400 ---------------------------------------------------------------------- .../main/java/org/apache/qpid/jms/provider/NoOpAsyncResult.java | 2 +- .../org/apache/qpid/jms/provider/amqp/AmqpConnectionSession.java | 4 ++-- .../java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java | 2 +- .../java/org/apache/qpid/jms/transports/TransportOptions.java | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/c99ea859/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/NoOpAsyncResult.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/NoOpAsyncResult.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/NoOpAsyncResult.java index 4cbc9b7..5bc7bdd 100644 --- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/NoOpAsyncResult.java +++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/NoOpAsyncResult.java @@ -21,7 +21,7 @@ package org.apache.qpid.jms.provider; */ public class NoOpAsyncResult implements AsyncResult { - public static NoOpAsyncResult INSTANCE = new NoOpAsyncResult(); + public final static NoOpAsyncResult INSTANCE = new NoOpAsyncResult(); @Override public void onFailure(Throwable result) { http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/c99ea859/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnectionSession.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnectionSession.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnectionSession.java index 04fc489..0a7c689 100644 --- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnectionSession.java +++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConnectionSession.java @@ -75,7 +75,7 @@ public class AmqpConnectionSession extends AmqpSession { builder.buildResource(subscribeRequest); } - private class DurableSubscriptionReattach extends AmqpAbstractResource<JmsSessionInfo, Receiver> { + private static final class DurableSubscriptionReattach extends AmqpAbstractResource<JmsSessionInfo, Receiver> { public DurableSubscriptionReattach(JmsSessionInfo resource, Receiver receiver, AmqpResourceParent parent) { super(resource, receiver, parent); @@ -119,7 +119,7 @@ public class AmqpConnectionSession extends AmqpSession { } } - private class DurableSubscriptionReattachRequest extends WrappedAsyncResult { + private final class DurableSubscriptionReattachRequest extends WrappedAsyncResult { private final DurableSubscriptionReattachBuilder subscriberBuilder; http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/c99ea859/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java index 11a7b15..916949c 100644 --- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java +++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java @@ -547,7 +547,7 @@ public class AmqpConsumer extends AmqpAbstractResource<JmsConsumerInfo, Receiver //----- Inner classes used in message pull operations --------------------// - protected class ScheduledStopRequest implements AsyncResult { + protected static final class ScheduledStopRequest implements AsyncResult { private final ScheduledFuture<?> sheduledStopTask; private final AsyncResult origRequest; http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/c99ea859/qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportOptions.java ---------------------------------------------------------------------- diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportOptions.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportOptions.java index c4d0b3e..14877f7 100644 --- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportOptions.java +++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportOptions.java @@ -19,7 +19,7 @@ package org.apache.qpid.jms.transports; /** * Encapsulates all the TCP Transport options in one configuration object. */ -public class TransportOptions { +public class TransportOptions implements Cloneable { public static final int DEFAULT_SEND_BUFFER_SIZE = 64 * 1024; public static final int DEFAULT_RECEIVE_BUFFER_SIZE = DEFAULT_SEND_BUFFER_SIZE; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
