Repository: qpid-proton Updated Branches: refs/heads/master 6a57a8c98 -> 06de5185d
NO-JIRA: ruby: remove perror calls in messenger library No library should *ever* write unsolicited output to stderr or stdout without being explicitly configured to do so. The connection closure in these two cases is reported to the calling app by closing the transport. Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/6e059675 Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/6e059675 Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/6e059675 Branch: refs/heads/master Commit: 6e059675a131bf6eaec651c9588adc1fb9a59ec4 Parents: 6a57a8c Author: Alan Conway <[email protected]> Authored: Wed Jan 13 12:11:58 2016 -0500 Committer: Alan Conway <[email protected]> Committed: Mon Sep 18 14:18:45 2017 -0400 ---------------------------------------------------------------------- proton-c/src/messenger/messenger.c | 2 -- 1 file changed, 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/6e059675/proton-c/src/messenger/messenger.c ---------------------------------------------------------------------- diff --git a/proton-c/src/messenger/messenger.c b/proton-c/src/messenger/messenger.c index 278ac89..01d7c99 100644 --- a/proton-c/src/messenger/messenger.c +++ b/proton-c/src/messenger/messenger.c @@ -255,7 +255,6 @@ static void pni_connection_readable(pn_selectable_t *sel) pn_transport_tail(transport), capacity); if (n <= 0) { if (n == 0 || !pn_wouldblock(messenger->io)) { - if (n < 0) perror("recv"); pn_transport_close_tail(transport); if (!(pn_connection_state(connection) & PN_REMOTE_CLOSED)) { pn_error_report("CONNECTION", "connection aborted (remote)"); @@ -285,7 +284,6 @@ static void pni_connection_writable(pn_selectable_t *sel) pn_transport_head(transport), pending); if (n < 0) { if (!pn_wouldblock(messenger->io)) { - perror("send"); pn_transport_close_head(transport); } } else { --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
