Repository: qpid-proton Updated Branches: refs/heads/master b2adecde3 -> 822d08deb
PROTON-1432: [go] Remove `func (Char) String` The Go/AMQP mapping is intended to use native Go types as much as possible. Where we introduce new types like Char, they should behave as much as possible like their Go counterparts. Removed `func (Char) String` because it behaves differently the underlying Go type `rune` Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/822d08de Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/822d08de Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/822d08de Branch: refs/heads/master Commit: 822d08deb1a6c58b023e5bfd3596dee727b84c45 Parents: b2adecd Author: Alan Conway <[email protected]> Authored: Wed Nov 22 10:57:23 2017 -0500 Committer: Alan Conway <[email protected]> Committed: Wed Nov 22 10:59:49 2017 -0500 ---------------------------------------------------------------------- proton-c/bindings/go/src/qpid.apache.org/amqp/types.go | 4 ---- proton-c/bindings/go/src/qpid.apache.org/amqp/types_test.go | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/822d08de/proton-c/bindings/go/src/qpid.apache.org/amqp/types.go ---------------------------------------------------------------------- diff --git a/proton-c/bindings/go/src/qpid.apache.org/amqp/types.go b/proton-c/bindings/go/src/qpid.apache.org/amqp/types.go index 513e90b..29cf866 100644 --- a/proton-c/bindings/go/src/qpid.apache.org/amqp/types.go +++ b/proton-c/bindings/go/src/qpid.apache.org/amqp/types.go @@ -247,8 +247,4 @@ func (u UUID) String() string { // It is defined as a distinct type so it can be distinguished from an AMQP int type Char rune -func (c Char) String() string { - return fmt.Sprintf("%c", c) -} - const intIs64 = unsafe.Sizeof(int(0)) == 8 http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/822d08de/proton-c/bindings/go/src/qpid.apache.org/amqp/types_test.go ---------------------------------------------------------------------- diff --git a/proton-c/bindings/go/src/qpid.apache.org/amqp/types_test.go b/proton-c/bindings/go/src/qpid.apache.org/amqp/types_test.go index 40f3968..e79ea1b 100644 --- a/proton-c/bindings/go/src/qpid.apache.org/amqp/types_test.go +++ b/proton-c/bindings/go/src/qpid.apache.org/amqp/types_test.go @@ -68,7 +68,7 @@ var rtValues = []interface{}{ Described{"D", "V"}, timeValue, UUID{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16}, - Char('\u2318'), + Char('a'), Map{"V": "X"}, Map{}, List{"V", int32(1)}, @@ -103,7 +103,7 @@ var vstrings = []string{ "{D V}", fmt.Sprintf("%v", timeValue), "UUID(01020304-0506-0708-090a-0b0c0d0e0f10)", - "\u2318", + fmt.Sprintf("%v", 'a'), "map[V:X]", "map[]", "[V 1]", --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
