QPID-8254: [Broker-J] Stop using illegal ascii characters in java keystore passwords
Project: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/commit/16b5592f Tree: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/tree/16b5592f Diff: http://git-wip-us.apache.org/repos/asf/qpid-broker-j/diff/16b5592f Branch: refs/heads/master Commit: 16b5592f12ccb841e432f5e16c4851c21ccc66cf Parents: 4ebae17 Author: Alex Rudyy <[email protected]> Authored: Tue Oct 30 15:29:02 2018 +0000 Committer: Alex Rudyy <[email protected]> Committed: Tue Oct 30 16:32:41 2018 +0000 ---------------------------------------------------------------------- .../qpid/server/security/AutoGeneratedSelfSignedKeyStoreImpl.java | 2 +- .../java/org/apache/qpid/server/security/NonJavaKeyStoreImpl.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/16b5592f/broker-core/src/main/java/org/apache/qpid/server/security/AutoGeneratedSelfSignedKeyStoreImpl.java ---------------------------------------------------------------------- diff --git a/broker-core/src/main/java/org/apache/qpid/server/security/AutoGeneratedSelfSignedKeyStoreImpl.java b/broker-core/src/main/java/org/apache/qpid/server/security/AutoGeneratedSelfSignedKeyStoreImpl.java index f596a8d..648f9fd 100644 --- a/broker-core/src/main/java/org/apache/qpid/server/security/AutoGeneratedSelfSignedKeyStoreImpl.java +++ b/broker-core/src/main/java/org/apache/qpid/server/security/AutoGeneratedSelfSignedKeyStoreImpl.java @@ -324,7 +324,7 @@ public class AutoGeneratedSelfSignedKeyStoreImpl java.security.KeyStore inMemoryKeyStore = java.security.KeyStore.getInstance(java.security.KeyStore.getDefaultType()); byte[] bytes = new byte[64]; - char[] chars = new char[64]; + char[] chars = "".toCharArray(); RANDOM.nextBytes(bytes); StandardCharsets.US_ASCII.decode(ByteBuffer.wrap(bytes)).get(chars); inMemoryKeyStore.load(null, chars); http://git-wip-us.apache.org/repos/asf/qpid-broker-j/blob/16b5592f/broker-core/src/main/java/org/apache/qpid/server/security/NonJavaKeyStoreImpl.java ---------------------------------------------------------------------- diff --git a/broker-core/src/main/java/org/apache/qpid/server/security/NonJavaKeyStoreImpl.java b/broker-core/src/main/java/org/apache/qpid/server/security/NonJavaKeyStoreImpl.java index 8beaf19..c8a4670 100644 --- a/broker-core/src/main/java/org/apache/qpid/server/security/NonJavaKeyStoreImpl.java +++ b/broker-core/src/main/java/org/apache/qpid/server/security/NonJavaKeyStoreImpl.java @@ -222,7 +222,7 @@ public class NonJavaKeyStoreImpl extends AbstractKeyStore<NonJavaKeyStoreImpl> i java.security.KeyStore inMemoryKeyStore = java.security.KeyStore.getInstance(java.security.KeyStore.getDefaultType()); byte[] bytes = new byte[64]; - char[] chars = new char[64]; + char[] chars = "".toCharArray(); RANDOM.nextBytes(bytes); StandardCharsets.US_ASCII.decode(ByteBuffer.wrap(bytes)).get(chars); inMemoryKeyStore.load(null, chars); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
