This is an automated email from the ASF dual-hosted git repository. gmurthy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git
The following commit(s) were added to refs/heads/master by this push: new a96e6ae DISPATCH-1454 - Fixed test_12 to use instanceof instead of __class__ and skipped test_39 until proton bug gets fixed a96e6ae is described below commit a96e6ae693cc998b0385aa018ede1e88d05922e1 Author: Ganesh Murthy <gmur...@apache.org> AuthorDate: Thu Oct 17 15:29:10 2019 -0400 DISPATCH-1454 - Fixed test_12 to use instanceof instead of __class__ and skipped test_39 until proton bug gets fixed --- tests/system_tests_one_router.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/system_tests_one_router.py b/tests/system_tests_one_router.py index da771f9..521113f 100644 --- a/tests/system_tests_one_router.py +++ b/tests/system_tests_one_router.py @@ -410,6 +410,7 @@ class OneRouterTest(TestCase): Tests connection property that is a binary map. The router ignores AMQP binary data type. Router should not return anything for connection properties """ + self.skipTest("Skipped until proton bug fixed.") connection = BlockingConnection(self.router.addresses[0], timeout=60, properties=CONNECTION_PROPERTIES_BINARY) @@ -520,7 +521,7 @@ class RouterProxy(object): def response(self, msg): ap = msg.properties bd = msg.body - if bd.__class__ == dict and 'results' in bd and 'attributeNames' in bd: + if isinstance(bd, dict) and 'results' in bd and 'attributeNames' in bd: ## ## This is a query response ## @@ -1986,9 +1987,10 @@ class StripMessageAnnotationsNoAddTrace ( MessagingHandler ) : notes = event.message.annotations - if notes.__class__ != dict : - self.bail ( "annotations are not a dictionary" ) + if not isinstance(notes, dict): + self.bail("annotations are not a dictionary") return + # No annotations should get stripped -- neither the # ones that the router adds, not the custome one that # I added. --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org For additional commands, e-mail: commits-h...@qpid.apache.org