This is an automated email from the ASF dual-hosted git repository.
cliffjansen pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-proton.git
The following commit(s) were added to refs/heads/main by this push:
new 9ddecea PROTON-2484: epoll proactor - missing null pointer logic
generously found by coverity
9ddecea is described below
commit 9ddecea80f366c6898671a2545b762a44b675052
Author: Cliff Jansen <[email protected]>
AuthorDate: Fri Jan 14 10:30:38 2022 -0800
PROTON-2484: epoll proactor - missing null pointer logic generously found
by coverity
---
c/src/proactor/epoll.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/c/src/proactor/epoll.c b/c/src/proactor/epoll.c
index e375f11..adce4cc 100644
--- a/c/src/proactor/epoll.c
+++ b/c/src/proactor/epoll.c
@@ -1476,18 +1476,18 @@ void pn_connection_wake(pn_connection_t* c) {
}
void pn_proactor_release_connection(pn_connection_t *c) {
- bool notify = false;
pconnection_t *pc = get_pconnection(c);
- pn_proactor_t *p = pc->task.proactor;
if (pc) {
+ bool notify = false;
+ pn_proactor_t *p = pc->task.proactor;
set_pconnection(c, NULL);
lock(&pc->task.mutex);
pn_connection_driver_release_connection(&pc->driver);
pconnection_begin_close(pc);
notify = schedule(&pc->task);
unlock(&pc->task.mutex);
+ if (notify) notify_poller(p);
}
- if (notify) notify_poller(p);
}
// ========================================================================
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
