This is an automated email from the ASF dual-hosted git repository.

jdanek pushed a commit to branch jd_tryout
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git

commit 2420bb3cd266207e427e8829da7fea1da360ce40
Author: Jiri DanÄ›k <[email protected]>
AuthorDate: Sun Jan 30 18:56:36 2022 +0100

    fixup freeing closing server DISPATCH-2323 Add Pytest-compatible logging 
displayed on test failure
---
 tests/system_tests_http1_adaptor.py | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/tests/system_tests_http1_adaptor.py 
b/tests/system_tests_http1_adaptor.py
index 3800012..82c2382 100644
--- a/tests/system_tests_http1_adaptor.py
+++ b/tests/system_tests_http1_adaptor.py
@@ -208,13 +208,15 @@ class Http1AdaptorManagementTest(TestCase):
         self.assertEqual(1, 
len(e_mgmt.query(type=self.CONNECTOR_TYPE).results))
 
         server = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-        server.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
-        server.bind(("", self.http_server_port))
-        server.setblocking(True)
-        server.settimeout(5)
-        server.listen(1)
-        conn, _ = server.accept()
-        server.close()
+        try:
+            server.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
+            server.bind(("", self.http_server_port))
+            server.setblocking(True)
+            server.settimeout(5)
+            server.listen(1)
+            conn, _ = server.accept()
+        finally:
+            server.close()
 
         # now check the interior router for the closest/http1Service address
         self.i_router.wait_address("closest/http1Service", subscribers=1)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to