This is an automated email from the ASF dual-hosted git repository.
tabish pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-protonj2.git
The following commit(s) were added to refs/heads/main by this push:
new 1c612786 PROTON-2541 Fix test assertion that can fail on race in frame
arrival
1c612786 is described below
commit 1c6127863afd1c20e18aa60b61ac88306f8df657
Author: Timothy Bish <[email protected]>
AuthorDate: Fri May 6 14:59:09 2022 -0400
PROTON-2541 Fix test assertion that can fail on race in frame arrival
Also fix an issue in some Javadocs in updated StreamDelivery docs
---
.../src/main/java/org/apache/qpid/protonj2/client/StreamDelivery.java | 2 --
.../java/org/apache/qpid/protonj2/client/impl/StreamSenderTest.java | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git
a/protonj2-client/src/main/java/org/apache/qpid/protonj2/client/StreamDelivery.java
b/protonj2-client/src/main/java/org/apache/qpid/protonj2/client/StreamDelivery.java
index 7a971732..3233dab5 100644
---
a/protonj2-client/src/main/java/org/apache/qpid/protonj2/client/StreamDelivery.java
+++
b/protonj2-client/src/main/java/org/apache/qpid/protonj2/client/StreamDelivery.java
@@ -51,8 +51,6 @@ public interface StreamDelivery {
* @return a {@link Message} instance that wraps the decoded payload.
*
* @throws ClientException if an error occurs while decoding the payload.
- *
- * @param <E> The type of message body that should be contained in the
returned {@link Message}.
*/
StreamReceiverMessage message() throws ClientException;
diff --git
a/protonj2-client/src/test/java/org/apache/qpid/protonj2/client/impl/StreamSenderTest.java
b/protonj2-client/src/test/java/org/apache/qpid/protonj2/client/impl/StreamSenderTest.java
index f1e3aae3..338cc178 100644
---
a/protonj2-client/src/test/java/org/apache/qpid/protonj2/client/impl/StreamSenderTest.java
+++
b/protonj2-client/src/test/java/org/apache/qpid/protonj2/client/impl/StreamSenderTest.java
@@ -1751,7 +1751,7 @@ public class StreamSenderTest extends
ImperativeClientTestCase {
peer.expectClose().respond();
assertNotNull(message.tracker());
- assertFalse(message.tracker().settlementFuture().isDone());
+ Wait.assertTrue(() ->
message.tracker().settlementFuture().isDone());
assertTrue(message.tracker().settlementFuture().get().settled());
sender.closeAsync().get(10, TimeUnit.SECONDS);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
