This is an automated email from the ASF dual-hosted git repository.
tabish pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-protonj2.git
The following commit(s) were added to refs/heads/main by this push:
new d4cf3ed5 PROTON-2780 Adjust timeout and add test code to fix race
d4cf3ed5 is described below
commit d4cf3ed5844c6a3fbfb8d9048c3272ddc8f7b61b
Author: Timothy Bish <[email protected]>
AuthorDate: Thu Dec 7 17:24:23 2023 -0500
PROTON-2780 Adjust timeout and add test code to fix race
Adds some expectations in test peer tests to ensure operations complete
as expected before asserting test state, adjust a few more timeouts for
slow CI instance.
---
.../java/org/apache/qpid/protonj2/client/impl/SessionTest.java | 8 ++++----
.../apache/qpid/protonj2/test/driver/ProtonTestClientTest.java | 2 ++
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git
a/protonj2-client/src/test/java/org/apache/qpid/protonj2/client/impl/SessionTest.java
b/protonj2-client/src/test/java/org/apache/qpid/protonj2/client/impl/SessionTest.java
index 475fa56b..0d4cab58 100644
---
a/protonj2-client/src/test/java/org/apache/qpid/protonj2/client/impl/SessionTest.java
+++
b/protonj2-client/src/test/java/org/apache/qpid/protonj2/client/impl/SessionTest.java
@@ -314,7 +314,7 @@ public class SessionTest extends ImperativeClientTestCase {
Client container = Client.create();
Connection connection = container.connect(remoteURI.getHost(),
remoteURI.getPort());
- SessionOptions options = new SessionOptions().openTimeout(120,
TimeUnit.MILLISECONDS);
+ SessionOptions options = new SessionOptions().openTimeout(250,
TimeUnit.MILLISECONDS);
Session session = connection.openSession(options);
peer.waitForScriptToComplete(5, TimeUnit.SECONDS);
@@ -379,7 +379,7 @@ public class SessionTest extends ImperativeClientTestCase {
Client container = Client.create();
Connection connection = container.connect(remoteURI.getHost(),
remoteURI.getPort());
connection.openFuture().get();
- SessionOptions options = new SessionOptions().openTimeout(125);
+ SessionOptions options = new SessionOptions().openTimeout(250);
Session session = connection.openSession(options);
peer.waitForScriptToComplete(5, TimeUnit.SECONDS);
@@ -441,7 +441,7 @@ public class SessionTest extends ImperativeClientTestCase {
Client container = Client.create();
Connection connection = container.connect(remoteURI.getHost(),
remoteURI.getPort());
- SessionOptions options = new SessionOptions().openTimeout(125);
+ SessionOptions options = new SessionOptions().openTimeout(250);
Session session = connection.openSession(options);
peer.waitForScriptToComplete(5, TimeUnit.SECONDS);
@@ -501,7 +501,7 @@ public class SessionTest extends ImperativeClientTestCase {
Connection connection = container.connect(remoteURI.getHost(),
remoteURI.getPort(), options);
connection.openFuture().get();
- SessionOptions sessionOptions = new
SessionOptions().openTimeout(125, TimeUnit.MILLISECONDS);
+ SessionOptions sessionOptions = new
SessionOptions().openTimeout(250, TimeUnit.MILLISECONDS);
try {
connection.openSession(sessionOptions).closeAsync().get();
diff --git
a/protonj2-test-driver/src/test/java/org/apache/qpid/protonj2/test/driver/ProtonTestClientTest.java
b/protonj2-test-driver/src/test/java/org/apache/qpid/protonj2/test/driver/ProtonTestClientTest.java
index ae5f98b6..f3c533aa 100644
---
a/protonj2-test-driver/src/test/java/org/apache/qpid/protonj2/test/driver/ProtonTestClientTest.java
+++
b/protonj2-test-driver/src/test/java/org/apache/qpid/protonj2/test/driver/ProtonTestClientTest.java
@@ -67,7 +67,9 @@ class ProtonTestClientTest extends TestPeerTestsBase {
public void testTwoClientConnectionsAndExchangeAMQPHeaders() throws
Exception {
try (ProtonTestServer peer = new ProtonTestServer()) {
peer.expectAMQPHeader().respondWithAMQPHeader();
+ peer.expectConnectionToDrop();
peer.expectAMQPHeader().respondWithAMQPHeader();
+ peer.expectConnectionToDrop();
peer.start();
URI remoteURI = peer.getServerURI();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
