(qpid-broker-j) branch main updated: QPID-8667: [Broker-J] Database connection with client certificate authentication exposes keystore / truststore passwords (#240)

[vavrtom]

This is an automated email from the ASF dual-hosted git repository.

vavrtom pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-broker-j.git


The following commit(s) were added to refs/heads/main by this push:
     new 4551a7eddf QPID-8667: [Broker-J] Database connection with client 
certificate authentication exposes keystore / truststore passwords (#240)
4551a7eddf is described below

commit 4551a7eddf8556ac5991f11ed92b6d6655cd4cef
Author: Daniil Kirilyuk <daniel.kiril...@gmail.com>
AuthorDate: Thu Feb 8 10:38:17 2024 +0100

    QPID-8667: [Broker-J] Database connection with client certificate 
authentication exposes keystore / truststore passwords (#240)
    
    added UI fix for the issue when creating a JSON Virtual Host Node with BDB 
Virtual host resulting in "dijit.registry.byId(...) is undefined" error
---
 .../management-http/src/main/java/resources/footer.html      |  2 +-
 .../js/qpid/management/addVirtualHostNodeAndVirtualHost.js   | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/broker-plugins/management-http/src/main/java/resources/footer.html 
b/broker-plugins/management-http/src/main/java/resources/footer.html
index 3611a36483..2abfb88fa6 100644
--- a/broker-plugins/management-http/src/main/java/resources/footer.html
+++ b/broker-plugins/management-http/src/main/java/resources/footer.html
@@ -19,7 +19,7 @@
  -
  -->
 
-<div class="footer"><p>&#xA9; 2004-<span class="currentYear">2023</span> The 
Apache Software Foundation.
+<div class="footer"><p>&#xA9; 2004-<span class="currentYear">2024</span> The 
Apache Software Foundation.
   <br/>
   Apache Qpid, Qpid, Apache, the Apache feather logo, and the Apache Qpid 
project logo are trademarks of
   The Apache Software Foundation.
diff --git 
a/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addVirtualHostNodeAndVirtualHost.js
 
b/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addVirtualHostNodeAndVirtualHost.js
index f89ab9d2c7..b2c8cb40ab 100644
--- 
a/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addVirtualHostNodeAndVirtualHost.js
+++ 
b/broker-plugins/management-http/src/main/java/resources/js/qpid/management/addVirtualHostNodeAndVirtualHost.js
@@ -397,37 +397,37 @@ define(["dojo/_base/event",
                         virtualHostData["context"] = virtualHostContext;
                     }
 
-                    const keystore = 
dijit.registry.byId('addVirtualHost.keyStore').get('value');
+                    const keystore = 
dijit.registry.byId("addVirtualHost.keyStore")?.get('value');
                     if (keystore)
                     {
                         virtualHostData["keyStore"] = keystore;
                     }
 
-                    const keystorePathPropertyName = 
dijit.registry.byId("addVirtualHost.keyStorePathPropertyName").get("value");
+                    const keystorePathPropertyName = 
dijit.registry.byId("addVirtualHost.keyStorePathPropertyName")?.get("value");
                     if (keystorePathPropertyName)
                     {
                         virtualHostData["keystorePathPropertyName"] = 
keystorePathPropertyName;
                     }
 
-                    const keystorePasswordPropertyName = 
dijit.registry.byId("addVirtualHost.keyStorePasswordPropertyName").get("value");
+                    const keystorePasswordPropertyName = 
dijit.registry.byId("addVirtualHost.keyStorePasswordPropertyName")?.get("value");
                     if (keystorePasswordPropertyName)
                     {
                         virtualHostData["keystorePasswordPropertyName"] = 
keystorePasswordPropertyName;
                     }
 
-                    const truststore = 
dijit.registry.byId("addVirtualHost.trustStore").get("value");
+                    const truststore = 
dijit.registry.byId("addVirtualHost.trustStore")?.get("value");
                     if (truststore)
                     {
                         virtualHostData["trustStore"] = truststore;
                     }
 
-                    const truststorePathPropertyName = 
dijit.registry.byId("addVirtualHost.trustStorePathPropertyName").get("value");
+                    const truststorePathPropertyName = 
dijit.registry.byId("addVirtualHost.trustStorePathPropertyName")?.get("value");
                     if (truststorePathPropertyName)
                     {
                         virtualHostData["truststorePathPropertyName"] = 
truststorePathPropertyName;
                     }
 
-                    const truststorePasswordPropertyName = 
dijit.registry.byId("addVirtualHost.trustStorePasswordPropertyName").get("value");
+                    const truststorePasswordPropertyName = 
dijit.registry.byId("addVirtualHost.trustStorePasswordPropertyName")?.get("value");
                     if (truststorePasswordPropertyName)
                     {
                         virtualHostData["truststorePasswordPropertyName"] = 
truststorePasswordPropertyName;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org
For additional commands, e-mail: commits-h...@qpid.apache.org