Repository: ranger
Updated Branches:
  refs/heads/master 478f5ffc7 -> 2cc88970b


RANGER-1836 LOG class is imported error for RangerServiceService class

Signed-off-by: peng.jianhua <[email protected]>


Project: http://git-wip-us.apache.org/repos/asf/ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/2cc88970
Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/2cc88970
Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/2cc88970

Branch: refs/heads/master
Commit: 2cc88970bea34cdeac92182572a5046f09a70306
Parents: 478f5ff
Author: zhangqiang2 <[email protected]>
Authored: Fri Oct 13 17:52:06 2017 +0800
Committer: peng.jianhua <[email protected]>
Committed: Sat Oct 14 10:16:39 2017 +0800

----------------------------------------------------------------------
 .../apache/ranger/service/RangerServiceService.java    | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ranger/blob/2cc88970/security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
----------------------------------------------------------------------
diff --git 
a/security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
 
b/security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
index 3dd761a..df3fdb5 100644
--- 
a/security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
+++ 
b/security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
@@ -25,13 +25,13 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
-import java.util.logging.Logger;
 
 import org.apache.commons.lang.StringUtils;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.apache.ranger.biz.ServiceDBStore;
 import org.apache.ranger.common.AppConstants;
 import org.apache.ranger.common.JSONUtil;
-import org.apache.ranger.plugin.util.PasswordUtils;
 import org.apache.ranger.common.PropertiesUtil;
 import org.apache.ranger.common.view.VTrxLogAttr;
 import org.apache.ranger.db.XXServiceVersionInfoDao;
@@ -41,6 +41,7 @@ import org.apache.ranger.entity.XXServiceDef;
 import org.apache.ranger.entity.XXServiceVersionInfo;
 import org.apache.ranger.entity.XXTrxLog;
 import org.apache.ranger.plugin.model.RangerService;
+import org.apache.ranger.plugin.util.PasswordUtils;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Scope;
 import org.springframework.stereotype.Service;
@@ -48,7 +49,7 @@ import org.springframework.stereotype.Service;
 @Service
 @Scope("singleton")
 public class RangerServiceService extends RangerServiceServiceBase<XXService, 
RangerService> {
-       private static final Logger LOG = 
Logger.getLogger(RangerServiceService.class.getName());
+       private static final Log LOG = 
LogFactory.getLog(RangerServiceService.class.getName());
        @Autowired
        JSONUtil jsonUtil;
 
@@ -166,9 +167,9 @@ public class RangerServiceService extends 
RangerServiceServiceBase<XXService, Ra
                                }
                        }
                } catch (IllegalAccessException e) {
-                       LOG.info("Get transaction log failure." + e);
+                       LOG.error("Transaction log failure.", e);
                } catch (NoSuchFieldException e) {
-                       LOG.info("Get transaction log failure." + e);
+                       LOG.error("Transaction log failure.", e);
                }
                return trxLogList;
        }
@@ -275,7 +276,7 @@ public class RangerServiceService extends 
RangerServiceServiceBase<XXService, Ra
                                xTrxLog.setNewValue(value);
                        }
                } catch (IllegalArgumentException | IllegalAccessException e) {
-                       LOG.info("Process field to create trx log failure." + 
e);
+                       LOG.error("Process field to create trx log failure." , 
e);
                }
 
                xTrxLog.setAction(actionString);

Reply via email to