Repository: ranger Updated Branches: refs/heads/master 454be055e -> c1b9b90d1
RANGER-1859:Fix new findBugs in HdfsClient.java Signed-off-by: peng.jianhua <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/ranger/repo Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/c1b9b90d Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/c1b9b90d Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/c1b9b90d Branch: refs/heads/master Commit: c1b9b90d1ba28b49791dac5877ef8ed643e3fc7b Parents: 454be05 Author: zhangqiang2 <[email protected]> Authored: Fri Oct 27 17:08:39 2017 +0800 Committer: peng.jianhua <[email protected]> Committed: Mon Oct 30 06:35:49 2017 +0800 ---------------------------------------------------------------------- .../org/apache/ranger/services/hdfs/client/HdfsClient.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ranger/blob/c1b9b90d/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java ---------------------------------------------------------------------- diff --git a/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java b/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java index 39fb9e8..55f5980 100644 --- a/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java +++ b/hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java @@ -290,7 +290,7 @@ public class HdfsClient extends BaseClient { } if (fsDefaultNameElements != null && fsDefaultNameElements.length >= 2) { String cluster = ""; - String clusters = ""; + StringBuilder clusters = new StringBuilder(); configs.put("dfs.nameservices", "hdfscluster"); configs.put("fs.default.name", "hdfs://" + configs.get("dfs.nameservices")); configs.put("dfs.client.failover.proxy.provider." + configs.get("dfs.nameservices"), @@ -300,12 +300,12 @@ public class HdfsClient extends BaseClient { configs.put("dfs.namenode.rpc-address." + configs.get("dfs.nameservices") + "." + cluster, fsDefaultNameElements[i]); if (i == (fsDefaultNameElements.length - 1)) { - clusters += cluster; + clusters.append(cluster); } else { - clusters += cluster + ","; + clusters.append(cluster).append(","); } } - configs.put("dfs.ha.namenodes." + configs.get("dfs.nameservices"), clusters); + configs.put("dfs.ha.namenodes." + configs.get("dfs.nameservices"), clusters.toString()); } }
