This is an automated email from the ASF dual-hosted git repository.

rmani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ranger.git


The following commit(s) were added to refs/heads/master by this push:
     new e3c642e  RANGER-2615:Unable to create Role
e3c642e is described below

commit e3c642e415f1d805236422b0c0f888cb61ce3362
Author: rmani <[email protected]>
AuthorDate: Thu Oct 10 02:26:21 2019 -0700

    RANGER-2615:Unable to create Role
    
    Signed-off-by: rmani <[email protected]>
---
 .../src/main/java/org/apache/ranger/db/XXGlobalStateDao.java      | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java 
b/security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java
index 4f7e9d5..38cb1fd 100644
--- a/security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java
+++ b/security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java
@@ -74,7 +74,7 @@ public class XXGlobalStateDao extends BaseDao<XXGlobalState> {
             try {
                 XXGlobalState globalState = findByStateName(stateName);
                 if (globalState == null) {
-                    createGlobalStateForRoleVersion(globalState, stateName);
+                    createGlobalStateForRoleVersion(stateName);
                 } else {
                     updateGlobalStateForRoleVersion(globalState, stateName);
                 }
@@ -136,7 +136,8 @@ public class XXGlobalStateDao extends 
BaseDao<XXGlobalState> {
         }
     }
 
-    private void createGlobalStateForRoleVersion(XXGlobalState globalState, 
String stateName) {
+    private void createGlobalStateForRoleVersion(String stateName) {
+        XXGlobalState globalState = new XXGlobalState();
         globalState.setStateName(stateName);
         Map<String,String> roleVersion = new HashMap<>();
         roleVersion.put(APP_DATA_ENTRY_ROLE_VERSION,new 
String(Long.toString(1L)));
@@ -153,8 +154,7 @@ public class XXGlobalStateDao extends 
BaseDao<XXGlobalState> {
             update(globalState);
         } else {
             //if not present create Global State for Role Version.
-            XXGlobalState xxGlobalState = new XXGlobalState();
-            createGlobalStateForRoleVersion(xxGlobalState, stateName);
+            createGlobalStateForRoleVersion(stateName);
         }
     }
 }

Reply via email to