This is an automated email from the ASF dual-hosted git repository.

rmani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ranger.git


The following commit(s) were added to refs/heads/master by this push:
     new cbe28e2  RANGER-3187:Roles download failed in Ranger after upgrade
cbe28e2 is described below

commit cbe28e250fbb0ef578a76ba3ebd0e6efb92f3366
Author: Ramesh Mani <[email protected]>
AuthorDate: Tue Feb 23 12:43:06 2021 -0800

    RANGER-3187:Roles download failed in Ranger after upgrade
---
 .../org/apache/ranger/patch/PatchForXGlobalState_J10036.java  | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git 
a/security-admin/src/main/java/org/apache/ranger/patch/PatchForXGlobalState_J10036.java
 
b/security-admin/src/main/java/org/apache/ranger/patch/PatchForXGlobalState_J10036.java
index 230c6a5..10cd283 100644
--- 
a/security-admin/src/main/java/org/apache/ranger/patch/PatchForXGlobalState_J10036.java
+++ 
b/security-admin/src/main/java/org/apache/ranger/patch/PatchForXGlobalState_J10036.java
@@ -19,6 +19,7 @@ package org.apache.ranger.patch;
 
 import com.google.gson.Gson;
 import org.apache.commons.collections.MapUtils;
+import org.apache.commons.lang.StringUtils;
 import org.apache.log4j.Logger;
 import org.apache.ranger.db.RangerDaoManager;
 import org.apache.ranger.entity.XXGlobalState;
@@ -74,10 +75,12 @@ public class PatchForXGlobalState_J10036 extends BaseLoader 
{
                        if (MapUtils.isNotEmpty(appDataVersionJson)) {
                                logger.info("Updating globalstate appdata 
version for = " + appDataVersionJson);
                                String roleVersion = 
appDataVersionJson.get("RangerRoleVersion");
-                               appDataVersionJson.put("Version", roleVersion);
-                               appDataVersionJson.remove("RangerRoleVersion");
-                               globalState.setAppData(new 
Gson().toJson(appDataVersionJson));
-                               
daoManager.getXXGlobalState().update(globalState);
+                               if (StringUtils.isNotEmpty(roleVersion)) {
+                                       appDataVersionJson.put("Version", 
roleVersion);
+                                       
appDataVersionJson.remove("RangerRoleVersion");
+                                       globalState.setAppData(new 
Gson().toJson(appDataVersionJson));
+                                       
daoManager.getXXGlobalState().update(globalState);
+                               }
                        }
                }
        }

Reply via email to