This is an automated email from the ASF dual-hosted git repository.

madhan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ranger.git


The following commit(s) were added to refs/heads/master by this push:
     new c874029de RANGER-3978: Docker minor updates to README.md, fix in 
create-ranger-services.py - #4
c874029de is described below

commit c874029de1bb364014b6c64e3d5560c02dd47e06
Author: Madhan Neethiraj <[email protected]>
AuthorDate: Wed Dec 21 12:12:06 2022 -0800

    RANGER-3978: Docker minor updates to README.md, fix in 
create-ranger-services.py - #4
---
 dev-support/ranger-docker/README.md                         | 13 +++++++------
 dev-support/ranger-docker/scripts/create-ranger-services.py |  6 ++----
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/dev-support/ranger-docker/README.md 
b/dev-support/ranger-docker/README.md
index 37bbc198d..d6337329e 100644
--- a/dev-support/ranger-docker/README.md
+++ b/dev-support/ranger-docker/README.md
@@ -42,35 +42,36 @@ Docker files in this folder create docker images and run 
them to build Apache Ra
    export RANGER_DB_TYPE=postgres
    ~~~
 
-5. Build Apache Ranger in containers using docker-compose
+6. Build Apache Ranger in containers using docker-compose
 
    1. Execute following command to build Apache Ranger:
       ~~~
       docker-compose -f docker-compose.ranger-base.yml -f 
docker-compose.ranger-build.yml up
       ~~~
 
-      Time taken to complete the build might vary (upto an hour), depending on 
status of ${HOME}/.m2 directory cache.
-   
+      Time taken to complete the build might vary (upto an hour), depending on 
status of ```${HOME}/.m2``` directory cache.
+
    2. Alternatively, the following commands can be executed from the parent 
directory
       1. To generate tarballs:```mvn clean package -DskipTests```
-      
+
       2. Copy the tarballs and version file to 
```dev-support/ranger-docker/dist```
          ~~~
          cp target/ranger-* dev-support/ranger-docker/dist/
          cp target/version dev-support/ranger-docker/dist/
          ~~~
+
       3. Build the ranger-base image:
          ~~~
          docker-compose -f docker-compose.ranger-base.yml build --no-cache
          ~~~
-         
+
 7. Execute following command to start Ranger, Ranger enabled 
HDFS/YARN/HBase/Hive/Kafka/Knox and dependent services (Solr, DB) in containers:
    ~~~
    docker-compose -f docker-compose.ranger-base.yml -f 
docker-compose.ranger.yml -f docker-compose.ranger-${RANGER_DB_TYPE}.yml -f 
docker-compose.ranger-usersync.yml -f docker-compose.ranger-tagsync.yml -f 
docker-compose.ranger-kms.yml -f docker-compose.ranger-hadoop.yml -f 
docker-compose.ranger-hbase.yml -f docker-compose.ranger-kafka.yml -f 
docker-compose.ranger-hive.yml -f docker-compose.ranger-knox.yml up -d
    ~~~
 
        - valid values for RANGER_DB_TYPE: mysql or postgres
-      
+
 8. To rebuild specific images and start containers with the new image, use 
following command:
    ~~~
    docker-compose -f docker-compose.ranger-base.yml -f 
docker-compose.ranger.yml -f docker-compose.ranger-usersync.yml -f 
docker-compose.ranger-tagsync.yml -f docker-compose.ranger-kms.yml -f 
docker-compose.ranger-hadoop.yml -f docker-compose.ranger-hbase.yml -f 
docker-compose.ranger-kafka.yml -f docker-compose.ranger-hive.yml -f 
docker-compose.ranger-knox.yml up -d --no-deps --force-recreate --build 
<service-1> <service-2>
diff --git a/dev-support/ranger-docker/scripts/create-ranger-services.py 
b/dev-support/ranger-docker/scripts/create-ranger-services.py
index 0903c38ea..c9ab3263c 100644
--- a/dev-support/ranger-docker/scripts/create-ranger-services.py
+++ b/dev-support/ranger-docker/scripts/create-ranger-services.py
@@ -7,12 +7,10 @@ ranger_client = RangerClient('http://ranger:6080', ('admin', 
'rangerR0cks!'))
 
 def service_not_exists(service):
     try:
-        res = ranger_client.get_service(service.name)
-        if res is None:
-            return 1
+        svc = ranger_client.get_service(service.name)
     except JSONDecodeError:
         return 1
-    return 0
+    return 0 if svc is not None else 1
 
 
 hdfs = RangerService({'name': 'dev_hdfs', 'type': 'hdfs',

Reply via email to