Repository: incubator-ranger
Updated Branches:
  refs/heads/master d03332064 -> 3c2facfda


RANGER-493 : Fix KMS dba script to work from non-install location

Signed-off-by: sneethiraj <[email protected]>


Project: http://git-wip-us.apache.org/repos/asf/incubator-ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ranger/commit/3c2facfd
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ranger/tree/3c2facfd
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ranger/diff/3c2facfd

Branch: refs/heads/master
Commit: 3c2facfda17d05089935ecdb8adbad40bd41f393
Parents: d033320
Author: Gautam Borad <[email protected]>
Authored: Tue May 19 11:15:40 2015 +0530
Committer: sneethiraj <[email protected]>
Committed: Tue May 19 03:05:51 2015 -0400

----------------------------------------------------------------------
 kms/scripts/db_setup.py   | 14 ++++++++------
 kms/scripts/dba_script.py | 30 ++++++++++++++++--------------
 2 files changed, 24 insertions(+), 20 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/3c2facfd/kms/scripts/db_setup.py
----------------------------------------------------------------------
diff --git a/kms/scripts/db_setup.py b/kms/scripts/db_setup.py
index 792327b..e7aa9a1 100644
--- a/kms/scripts/db_setup.py
+++ b/kms/scripts/db_setup.py
@@ -32,9 +32,11 @@ os_name = platform.system()
 os_name = os_name.upper()
 
 if os_name == "LINUX":
-       RANGER_KMS_HOME = os.getcwd()
+    RANGER_KMS_HOME = os.getenv("RANGER_KMS_HOME")
+    if RANGER_KMS_HOME is None:
+        RANGER_KMS_HOME = os.getcwd()
 elif os_name == "WINDOWS":
-       RANGER_KMS_HOME = os.getenv("RANGER_KMS_HOME")
+    RANGER_KMS_HOME = os.getenv("RANGER_KMS_HOME")
 
 def check_output(query):
        if os_name == "LINUX":
@@ -119,7 +121,7 @@ class MysqlConf(BaseDB):
                path = RANGER_KMS_HOME
                self.JAVA_BIN = self.JAVA_BIN.strip("'")
                if os_name == "LINUX":
-                       jisql_cmd = "%s -cp %s:jisql/lib/* 
org.apache.util.sql.Jisql -driver mysqlconj -cstring jdbc:mysql://%s/%s -u %s 
-p %s -noheader -trim -c \;" 
%(self.JAVA_BIN,self.SQL_CONNECTOR_JAR,self.host,db_name,user,password)
+                       jisql_cmd = "%s -cp %s:%s/jisql/lib/* 
org.apache.util.sql.Jisql -driver mysqlconj -cstring jdbc:mysql://%s/%s -u %s 
-p %s -noheader -trim -c \;" 
%(self.JAVA_BIN,self.SQL_CONNECTOR_JAR,path,self.host,db_name,user,password)
                elif os_name == "WINDOWS":
                        jisql_cmd = "%s -cp %s;%s\jisql\\lib\\* 
org.apache.util.sql.Jisql -driver mysqlconj -cstring jdbc:mysql://%s/%s -u %s 
-p %s -noheader -trim" %(self.JAVA_BIN, self.SQL_CONNECTOR_JAR, path, 
self.host, db_name, user, password)
                return jisql_cmd
@@ -189,7 +191,7 @@ class OracleConf(BaseDB):
                path = RANGER_KMS_HOME
                self.JAVA_BIN = self.JAVA_BIN.strip("'")
                if os_name == "LINUX":
-                       jisql_cmd = "%s -cp %s:jisql/lib/* 
org.apache.util.sql.Jisql -driver oraclethin -cstring jdbc:oracle:thin:@%s -u 
'%s' -p '%s' -noheader -trim" %(self.JAVA_BIN, self.SQL_CONNECTOR_JAR, 
self.host, user, password)
+                       jisql_cmd = "%s -cp %s:%s/jisql/lib/* 
org.apache.util.sql.Jisql -driver oraclethin -cstring jdbc:oracle:thin:@%s -u 
'%s' -p '%s' -noheader -trim" %(self.JAVA_BIN, self.SQL_CONNECTOR_JAR,path, 
self.host, user, password)
                elif os_name == "WINDOWS":
                        jisql_cmd = "%s -cp %s;%s\jisql\\lib\\* 
org.apache.util.sql.Jisql -driver oraclethin -cstring jdbc:oracle:thin:@%s -u 
%s -p %s -noheader -trim" %(self.JAVA_BIN, self.SQL_CONNECTOR_JAR, path, 
self.host, user, password)
                return jisql_cmd
@@ -275,7 +277,7 @@ class PostgresConf(BaseDB):
                path = RANGER_KMS_HOME
                self.JAVA_BIN = self.JAVA_BIN.strip("'")
                if os_name == "LINUX":
-                       jisql_cmd = "%s -cp %s:jisql/lib/* 
org.apache.util.sql.Jisql -driver postgresql -cstring 
jdbc:postgresql://%s:5432/%s -u %s -p %s -noheader -trim -c \;" 
%(self.JAVA_BIN, self.SQL_CONNECTOR_JAR, self.host, db_name, user, password)
+                       jisql_cmd = "%s -cp %s:%s/jisql/lib/* 
org.apache.util.sql.Jisql -driver postgresql -cstring 
jdbc:postgresql://%s:5432/%s -u %s -p %s -noheader -trim -c \;" 
%(self.JAVA_BIN, self.SQL_CONNECTOR_JAR, path,self.host, db_name, user, 
password)
                elif os_name == "WINDOWS":
                        jisql_cmd = "%s -cp %s;%s\jisql\\lib\\* 
org.apache.util.sql.Jisql -driver postgresql -cstring 
jdbc:postgresql://%s:5432/%s -u %s -p %s -noheader -trim" %(self.JAVA_BIN, 
self.SQL_CONNECTOR_JAR, path, self.host, db_name, user, password)
                return jisql_cmd
@@ -345,7 +347,7 @@ class SqlServerConf(BaseDB):
                path = RANGER_KMS_HOME
                self.JAVA_BIN = self.JAVA_BIN.strip("'")
                if os_name == "LINUX":
-                       jisql_cmd = "%s -cp %s:jisql/lib/* 
org.apache.util.sql.Jisql -user %s -password %s -driver mssql -cstring 
jdbc:sqlserver://%s:1433\\;databaseName=%s -noheader -trim"%(self.JAVA_BIN, 
self.SQL_CONNECTOR_JAR, user, password, self.host,db_name)
+                       jisql_cmd = "%s -cp %s:%s/jisql/lib/* 
org.apache.util.sql.Jisql -user %s -password %s -driver mssql -cstring 
jdbc:sqlserver://%s:1433\\;databaseName=%s -noheader -trim"%(self.JAVA_BIN, 
self.SQL_CONNECTOR_JAR,path, user, password, self.host,db_name)
                elif os_name == "WINDOWS":
                        jisql_cmd = "%s -cp %s;%s\\jisql\\lib\\* 
org.apache.util.sql.Jisql -user %s -password %s -driver mssql -cstring 
jdbc:sqlserver://%s:1433;databaseName=%s -noheader -trim"%(self.JAVA_BIN, 
self.SQL_CONNECTOR_JAR, path, user, password, self.host,db_name)
                return jisql_cmd

http://git-wip-us.apache.org/repos/asf/incubator-ranger/blob/3c2facfd/kms/scripts/dba_script.py
----------------------------------------------------------------------
diff --git a/kms/scripts/dba_script.py b/kms/scripts/dba_script.py
index 0749038..327d5ca 100644
--- a/kms/scripts/dba_script.py
+++ b/kms/scripts/dba_script.py
@@ -31,9 +31,11 @@ os_name = platform.system()
 os_name = os_name.upper()
 
 if os_name == "LINUX":
+    RANGER_KMS_HOME = os.getenv("RANGER_KMS_HOME")
+    if RANGER_KMS_HOME is None:
         RANGER_KMS_HOME = os.getcwd()
 elif os_name == "WINDOWS":
-        RANGER_KMS_HOME = os.getenv("RANGER_KMS_HOME")
+    RANGER_KMS_HOME = os.getenv("RANGER_KMS_HOME")
 
 def call_keystore(libpath,aliasKey,aliasValue , filepath,getorcreate):
     finalLibPath = libpath.replace('\\','/').replace('//','/')
@@ -81,7 +83,7 @@ def populate_global_dict():
        elif os_name == "WINDOWS":
                read_config_file = 
open(os.path.join(RANGER_KMS_HOME,'bin','install_config.properties'))
        library_path = os.path.join(RANGER_KMS_HOME,"cred","lib","*")
-       read_config_file = open(os.path.join(os.getcwd(),'install.properties'))
+       read_config_file = 
open(os.path.join(RANGER_KMS_HOME,'install.properties'))
        for each_line in read_config_file.read().split('\n') :
                if len(each_line) == 0 : continue
                if re.search('=', each_line):
@@ -136,9 +138,9 @@ class MysqlConf(BaseDB):
 
        def get_jisql_cmd(self, user, password ,db_name):
                #TODO: User array for forming command
-               path = os.getcwd()
+               path = RANGER_KMS_HOME
                if os_name == "LINUX":
-                       jisql_cmd = "%s -cp %s:jisql/lib/* 
org.apache.util.sql.Jisql -driver mysqlconj -cstring jdbc:mysql://%s/%s -u %s 
-p %s -noheader -trim -c \;" 
%(self.JAVA_BIN,self.SQL_CONNECTOR_JAR,self.host,db_name,user,password)
+                       jisql_cmd = "%s -cp %s:%s/jisql/lib/* 
org.apache.util.sql.Jisql -driver mysqlconj -cstring jdbc:mysql://%s/%s -u %s 
-p %s -noheader -trim -c \;" 
%(self.JAVA_BIN,self.SQL_CONNECTOR_JAR,path,self.host,db_name,user,password)
                elif os_name == "WINDOWS":
                        self.JAVA_BIN = self.JAVA_BIN.strip("'")
                        jisql_cmd = "%s -cp %s;%s\jisql\\lib\\* 
org.apache.util.sql.Jisql -driver mysqlconj -cstring jdbc:mysql://%s/%s -u %s 
-p %s -noheader -trim" %(self.JAVA_BIN, self.SQL_CONNECTOR_JAR, path, 
self.host, db_name, user, password)
@@ -321,9 +323,9 @@ class OracleConf(BaseDB):
 
        def get_jisql_cmd(self, user, password):
                #TODO: User array for forming command
-               path = os.getcwd()
+               path = RANGER_KMS_HOME
                if os_name == "LINUX":
-                       jisql_cmd = "%s -cp %s:jisql/lib/* 
org.apache.util.sql.Jisql -driver oraclethin -cstring jdbc:oracle:thin:@%s -u 
'%s' -p '%s' -noheader -trim" %(self.JAVA_BIN, self.SQL_CONNECTOR_JAR, 
self.host, user, password)
+                       jisql_cmd = "%s -cp %s:%s/jisql/lib/* 
org.apache.util.sql.Jisql -driver oraclethin -cstring jdbc:oracle:thin:@%s -u 
'%s' -p '%s' -noheader -trim" %(self.JAVA_BIN, self.SQL_CONNECTOR_JAR,path, 
self.host, user, password)
                elif os_name == "WINDOWS":
                        jisql_cmd = "%s -cp %s;%s\jisql\\lib\\* 
org.apache.util.sql.Jisql -driver oraclethin -cstring jdbc:oracle:thin:@%s -u 
%s -p %s -noheader -trim" %(self.JAVA_BIN, self.SQL_CONNECTOR_JAR, path, 
self.host, user, password)
                return jisql_cmd
@@ -517,10 +519,10 @@ class PostgresConf(BaseDB):
 
        def get_jisql_cmd(self, user, password, db_name):
                #TODO: User array for forming command
-               path = os.getcwd()
+               path = RANGER_KMS_HOME
                self.JAVA_BIN = self.JAVA_BIN.strip("'")
                if os_name == "LINUX":
-                       jisql_cmd = "%s -cp %s:jisql/lib/* 
org.apache.util.sql.Jisql -driver postgresql -cstring 
jdbc:postgresql://%s:5432/%s -u %s -p %s -noheader -trim -c \;" 
%(self.JAVA_BIN, self.SQL_CONNECTOR_JAR, self.host, db_name, user, password)
+                       jisql_cmd = "%s -cp %s:%s/jisql/lib/* 
org.apache.util.sql.Jisql -driver postgresql -cstring 
jdbc:postgresql://%s:5432/%s -u %s -p %s -noheader -trim -c \;" 
%(self.JAVA_BIN, self.SQL_CONNECTOR_JAR, path,self.host, db_name, user, 
password)
                elif os_name == "WINDOWS":
                        jisql_cmd = "%s -cp %s;%s\jisql\\lib\\* 
org.apache.util.sql.Jisql -driver postgresql -cstring 
jdbc:postgresql://%s:5432/%s -u %s -p %s -noheader -trim" %(self.JAVA_BIN, 
self.SQL_CONNECTOR_JAR, path, self.host, db_name, user, password)
                return jisql_cmd
@@ -714,10 +716,10 @@ class SqlServerConf(BaseDB):
 
        def get_jisql_cmd(self, user, password, db_name):
                #TODO: User array for forming command
-               path = os.getcwd()
+               path = RANGER_KMS_HOME
                self.JAVA_BIN = self.JAVA_BIN.strip("'")
                if os_name == "LINUX":
-                       jisql_cmd = "%s -cp %s:jisql/lib/* 
org.apache.util.sql.Jisql -user %s -password %s -driver mssql -cstring 
jdbc:sqlserver://%s:1433\\;databaseName=%s -noheader -trim"%(self.JAVA_BIN, 
self.SQL_CONNECTOR_JAR, user, password, self.host,db_name)
+                       jisql_cmd = "%s -cp %s:%s/jisql/lib/* 
org.apache.util.sql.Jisql -user %s -password %s -driver mssql -cstring 
jdbc:sqlserver://%s:1433\\;databaseName=%s -noheader -trim"%(self.JAVA_BIN, 
self.SQL_CONNECTOR_JAR, path,user, password, self.host,db_name)
                elif os_name == "WINDOWS":
                        jisql_cmd = "%s -cp %s;%s\\jisql\\lib\\* 
org.apache.util.sql.Jisql -user %s -password %s -driver mssql -cstring 
jdbc:sqlserver://%s:1433;databaseName=%s -noheader -trim"%(self.JAVA_BIN, 
self.SQL_CONNECTOR_JAR, path, user, password, self.host,db_name)
                return jisql_cmd
@@ -1043,7 +1045,7 @@ def main(argv):
        if XA_DB_FLAVOR == "MYSQL":
                MYSQL_CONNECTOR_JAR=CONNECTOR_JAR
                xa_sqlObj = MysqlConf(xa_db_host, MYSQL_CONNECTOR_JAR, JAVA_BIN)
-               xa_db_core_file = os.path.join(os.getcwd(),mysql_core_file)
+               xa_db_core_file = os.path.join(RANGER_KMS_HOME,mysql_core_file)
 
        elif XA_DB_FLAVOR == "ORACLE":
                ORACLE_CONNECTOR_JAR=CONNECTOR_JAR
@@ -1052,17 +1054,17 @@ def main(argv):
                elif os_name == "WINDOWS":
                        xa_db_root_user = xa_db_root_user
                xa_sqlObj = OracleConf(xa_db_host, ORACLE_CONNECTOR_JAR, 
JAVA_BIN)
-               xa_db_core_file = os.path.join(os.getcwd(),oracle_core_file)
+               xa_db_core_file = os.path.join(RANGER_KMS_HOME,oracle_core_file)
 
        elif XA_DB_FLAVOR == "POSTGRES":
                POSTGRES_CONNECTOR_JAR=CONNECTOR_JAR
                xa_sqlObj = PostgresConf(xa_db_host, POSTGRES_CONNECTOR_JAR, 
JAVA_BIN)
-               xa_db_core_file = os.path.join(os.getcwd(),postgres_core_file)
+               xa_db_core_file = 
os.path.join(RANGER_KMS_HOME,postgres_core_file)
 
        elif XA_DB_FLAVOR == "MSSQL":
                SQLSERVER_CONNECTOR_JAR=CONNECTOR_JAR
                xa_sqlObj = SqlServerConf(xa_db_host, SQLSERVER_CONNECTOR_JAR, 
JAVA_BIN)
-               xa_db_core_file = os.path.join(os.getcwd(),sqlserver_core_file)
+               xa_db_core_file = 
os.path.join(RANGER_KMS_HOME,sqlserver_core_file)
        else:
                log("[E] ---------- NO SUCH SUPPORTED DB FLAVOUR.. ----------", 
"error")
                sys.exit(1)

Reply via email to